develooper Front page | perl.perl5.porters | Postings from September 2009

Re: Make makedef.pl build the command line from its own @INC

Thread Previous | Thread Next
From:
Max Maischein
Date:
September 24, 2009 13:03
Subject:
Re: Make makedef.pl build the command line from its own @INC
Message ID:
4ABBD08D.1080307@corion.net
Hello Nick,

>> Currently, makedef.pl hardcodes lib/ when it runs $^X to output 
>> variables from Config.pm. This is bad, because on Windows, it is run 
>> from win32/ instead. The attached patch lets makedef.pl build the 
>> command line dynamically by adding all of @INC as -I switches.
> 
> Would it also work to do
> 
>     $ENV{PERL5LIB} = join $Config{path_sep}, @INC;
> 
> before the ``?
> 
> That was the approach I took in make_ext.pl, and feels a bit more robust,
> as it should cope with any legal filename on the platform in question.
> (Except for anyone who puts ':' in a directory name on Unix. Or anywhere with
> shorter limits on environment variable length than command line length)
Yes. That approach is safer and it also works. Patch attached, but I 
fear it's on top of my previous patch.

-max

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About