develooper Front page | perl.perl5.porters | Postings from September 2009

Re: [PATCH] Reduce #ifdefs in Perl_ck_shift

Thread Previous | Thread Next
From:
Abhijit Menon-Sen
Date:
September 3, 2009 22:54
Subject:
Re: [PATCH] Reduce #ifdefs in Perl_ck_shift
Message ID:
20090904055426.GA12299@toroid.org
At 2009-09-03 15:31:34 -0400, gigabo@gmail.com wrote:
>
> I noticed this FIXME in op.c recently.

Thanks, applied (821005d).

Aside: to play nicely with git-am, you could try using git-send-email.
Your message as it was caused git-am put the "Hi, I noticed ..." text
into the commit message, which I then edited by hand.

If, instead, you send patch mail that looks like this (whether through
git-send-email or otherwise):

    From: Bo Borgerson <gigabo@gmail.com>
    To: perl5-porters@perl.org
    Subject: [PATCH] Reduce #ifdefs in Perl_ck_shift

    Rest of the commit message (if any), across multiple lines.

    ---

    [optional text that doesn't get included in the commit message]

     op.c |   11 +++--------
     1 files changed, 3 insertions(+), 8 deletions(-)

    diff --git a/op.c b/op.c
    ...

Then git-am does the right thing straightaway.

-- ams

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About