Front page | perl.perl5.porters |
Postings from September 2009
2009/8/3 Dave Mitchell <davem@iabyn.com>: > On Sun, Aug 02, 2009 at 08:12:37PM -0400, George Greer wrote: >> On Mon, 27 Jul 2009, Dave Mitchell wrote: >> >>> I'm having great difficulty pulling this into maint; specifically the >>> regexec.c part, due the changes in blead (but not maint) that made REGEXPs >>> into SVs; for example, the maint: >>> >>> Perl_regexec_flags(pTHX_ REGEXP * const prog, ... >>> >>> becomes the blead: >>> >>> Perl_regexec_flags(pTHX_ REGEXP * const rx, ... >>> ... >>> struct regexp *const prog = (struct regexp *)SvANY(rx); >>> >>> then theres lots of places in the function which sometimes refer to rx and >>> sometimes to prog, and I think it would require someone with a clearer >>> head than what mine is at the moment to work it all out :-( >> >> Doing a straight port and fixing up the conflicts passes the tests >> (perhaps by luck?). I've attached the patch, which has the commit >> message edited with a proper 1-line summary like the blead version did. > > Thanks, but given the closeness to 5.10.1 release, and the risk of this > patch, I think I'll defer it till after 5.10.1. So is it ok to go with it now? Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"Thread Previous | Thread Next