Front page | perl.perl5.porters |
Postings from August 2009
On Sat, Aug 29, 2009 at 22:46:23 +0200 , Flavio Poletti wrote:
> On Sat, Aug 29, 2009 at 9:44 PM, Ben Morrow <ben@morrow.me.uk> wrote:
>
> >
> > That said, let me begin the bikeshedding by saying that I really hate
> > the {'BAR'} style of hash element (as opposed to simply {BAR}). A quick
> > check
> >
> > perl% perl -nE'/\{\s*(["\47]?)\w+\1\s*\}/ and say $1' pod/* |
> > sort | uniq -c
> > 1128
> > 70 "
> > 178 '
> >
> > suggests the core docs agree with me (some of those are false positives
> > on things like *FOO{IO}, of course).
>
>
> Heh, I hate that too when it's not necessary, even though I used it. IIRC I
> bumped into one of those 178 with the single quote when making changes, and
> thought that the docs were recommending that style somewhere. I'll add
> another change to cope with this.
>
>
> > > Things I hope to remember in the future:
> >
> > If you're interested in review, then posting patches would be helpful.
> > It would probably be better to post something like that branch you have
> > their as a single diff for the sake of review, even though the commits
> > will hopefully be pulled separately.
>
>
> Thank you for the suggestion, I'll produce a diff and post it here (I'll do
> this for perldata as well, of course).
>
> Cheers,
>
> Flavio.
FWIW, it probably makes sense to use the style documented in perlstyle
where it's applicable (and in line with the current goals), for the sake
of consistency. For this issue, perlstyle suggests the rather Strunkian
"Omit redundant punctuation as long as clarity doesn’t suffer." We
should strive to be consistent above all else, so as to enhance clarity
and reduce confusion.
--
Best regards,
Chris Nehren
Thread Previous
|
Thread Next