develooper Front page | perl.perl5.porters | Postings from August 2009

Re: [perl #68792] usedtrace: make dependency failure

Thread Previous
From:
Rafael Garcia-Suarez
Date:
August 27, 2009 14:56
Subject:
Re: [perl #68792] usedtrace: make dependency failure
Message ID:
b77c1dce0908271456x753f8adfl2a0c6ed8889b3fb6@mail.gmail.com
2009/8/26 info@brak.cowlabs.com (via RT) <perlbug-followup@perl.org>:
> When usedtrace is defined, miniperl build target fails because the
> dtrace command that generates probe functions run.  The existing dtrace
> target lacks depencies on the object targets it needs (and subsequently
> needs miniperl to satisfy them).  The solution is to build a
> miniperldtrace.o for the miniperl build target and to include all
> non-dtrace objects as depencies for the miniperldtrace.o and
> perldtrace.o targets.  See diff below:

It seems that this patch breaks the compilation without dtrace support.

> --- Makefile.SH-orig    Wed Aug 26 00:40:57 2009
> +++ Makefile.SH Wed Aug 26 00:46:22 2009
> @@ -329,6 +329,7 @@
>  DTRACE = $dtrace
>  DTRACE_H = $dtrace_h
>  DTRACE_O = $dtrace_o
> +MINI_DTRACE_O = mini$dtrace_o
>
>  FIRSTMAKEFILE = $firstmakefile
>
> @@ -463,7 +464,8 @@
>  obj2 = hv$(OBJ_EXT) av$(OBJ_EXT) run$(OBJ_EXT) pp_hot$(OBJ_EXT) sv$(OBJ_EXT) pp$(OBJ_EXT) scope$(OBJ_EXT) pp_ctl$(OBJ_EXT) pp_sys$(OBJ_EXT)
>  obj3 = doop$(OBJ_EXT) doio$(OBJ_EXT) regexec$(OBJ_EXT) utf8$(OBJ_EXT) taint$(OBJ_EXT) deb$(OBJ_EXT) universal$(OBJ_EXT) xsutils$(OBJ_EXT) globals$(OBJ_EXT) perlio$(OBJ_EXT) perlapi$(OBJ_EXT) numeric$(OBJ_EXT) mathoms$(OBJ_EXT) locale$(OBJ_EXT) pp_pack$(OBJ_EXT) pp_sort$(OBJ_EXT)
>
> -mini_obj =  $(obj1) $(obj2) $(obj3) $(ARCHOBJS)
> +mini_ndt_obj =  $(obj1) $(obj2) $(obj3) $(ARCHOBJS)
> +mini_obj =  $(mini_ndt_obj) $(MINI_DTRACE_O)
>  ndt_obj = $(obj0) $(obj1) $(obj2) $(obj3) $(ARCHOBJS)
>  obj = $(ndt_obj) $(DTRACE_O)
>
> @@ -722,8 +724,10 @@
>        case "$dtrace_o" in
>        ?*)
>                $spitshell >>$Makefile <<'!NO!SUBS!'
> -$(DTRACE_O): perldtrace.d
> +$(DTRACE_O): perldtrace.d $(ndt_obj)
>        $(DTRACE) -G -s perldtrace.d -o $(DTRACE_O) $(ndt_obj)
> +$(MINI_DTRACE_O): perldtrace.d $(mini_ndt_obj)
> +       $(DTRACE) -G -s perldtrace.d -o $(MINI_DTRACE_O) $(mini_ndt_obj)
>
>  !NO!SUBS!

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About