Front page | perl.perl5.porters |
Postings from August 2009
Re: 5.10.1-RC2 is released
Thread Previous
|
Thread Next
From:
Merijn Broeren
Date:
August 20, 2009 06:32
Subject:
Re: 5.10.1-RC2 is released
Message ID:
20090820132412.GA12299@brugman.iloquent.nl
Quoting Nicholas Clark (nick@ccl4.org):
> On Thu, Aug 20, 2009 at 12:19:54PM +0200, Merijn Broeren wrote:
> > Quoting Dave Mitchell (davem@iabyn.com):
> > > I've just uploaded 5.10.1-RC2 to CPAN.
> > >
> > I get one test failure :
> >
> > Failed 1 test out of 1663, 99.94% okay.
> > ../lib/parent/t/parent-pmc.t
> >
> > which is most likely due to the fact that I compiled it with
> > -DPERL_DISABLE_PMC.
>
> Yes, I discovered this yesterday, and I've mailed a proposed patch for
> that test to Max Maischein.
>
I submitted a patch through perlbug just now. I looked at the best way
to skip this test but there doesn't seem to be a nice flag in Config.
Checking other tests I found only one related to this flag (ther e might
be more of course), t/comp/require.t. I adapted the code from that test
to skip the parent-pmc tests in the patch that follows.
I'm not sure skipping is the best solution, but it seems reasonable to
do so for this test if pmc files are disabled. We disable them to gain a
small performance advantage.
My patch:
--- /var/tmp/build.merijnb/parent-pmc.t 2009-08-20 08:37:43.000000000 -0400
+++ ./lib/parent/t/parent-pmc.t 2009-08-20 08:36:20.000000000 -0400
@@ -1,10 +1,18 @@
#!/usr/bin/perl -w
+
+my $ccflags;
BEGIN {
if( $ENV{PERL_CORE} ) {
chdir 't' if -d 't';
chdir '../lib/parent';
@INC = '..';
}
+ # Right. We really really need Config here.
+ require Config;
+ die "Failed to load Config for some reason"
+ unless $Config::Config{version};
+ $ccflags = $Config::Config{ccflags};
+ die "Failed to get ccflags for some reason" unless defined $ccflags;
}
use strict;
@@ -12,6 +20,7 @@
use lib 't/lib';
plan skip_all => ".pmc are only available with 5.6 and later" if $] < 5.006;
+plan skip_all => ".pmc files are ignored in this build" if ($ccflags =~ /(?:^|\s)-DPERL_DISABLE_PMC\b/);
plan tests => 3;
use vars qw($got_here);
> Hence why there was also this patch:
>
> http://perl5.git.perl.org/perl.git/commit/f89a1e08e6fb41e93df685b7f838ff9bf916
>
> diff --git a/perl.c b/perl.c
> index 34fb282..9ef9cd7 100644
> --- a/perl.c
> +++ b/perl.c
> @@ -1770,6 +1770,9 @@ S_parse_body(pTHX_ char **env, XSINIT_t xsinit)
> # ifdef NO_MATHOMS
> " NO_MATHOMS"
> # endif
> +# ifdef PERL_DISABLE_PMC
> + " PERL_DISABLE_PMC"
> +# endif
> # ifdef PERL_DONT_CREATE_GVSV
> " PERL_DONT_CREATE_GVSV"
> # endif
>
Yes, but that doesn't help with testing from inside a perl
program, correct me if I'm wrong...
Cheers,
--
Merijn Broeren | We take risks, we know we take them. Therefore, when things
| come out against us, we have no cause for complaint.
| - Scott, last journal entry, march 1912
Thread Previous
|
Thread Next