develooper Front page | perl.perl5.porters | Postings from August 2009

RE: [PATCH] cando for cygwin

Thread Previous
From:
Jan Dubois
Date:
August 10, 2009 21:28
Subject:
RE: [PATCH] cando for cygwin
Message ID:
022001ca1a3c$328b2460$97a16d20$@com
On Mon, 10 Aug 2009, Reini Urban wrote:
> I got a bugreport on cygwin by a user who forgot about use filetest
> 'access'. He was a Administrator and worried about the wrong writable
> flag, because access() is not called per default on -w checks
>
> So I added the gid 544 check to cando(), which is the short analog to
> unix root.

Your patch seems to be just a diff against a previous version of the same
patch as it only changes the order of the preprocessor branches.  It
also doesn't apply to any of the branches in the git repo.

Cheers,
-Jan

--- doio.c.orig 2009-08-11 04:41:00.750000000 +0200
+++ doio.c      2009-08-11 04:51:13.906250000 +0200
@@ -1926,10 +1926,10 @@
      return (mode & statbufp->st_mode) ? TRUE : FALSE;

 #else /* ! DOSISH */
-#ifdef __CYGWIN__
-    if ((effective ? PL_egid : PL_gid) == 544) { /* member of Administrators? */
-#else
+#if !defined(__CYGWIN__)
     if ((effective ? PL_euid : PL_uid) == 0) { /* root is special */
+#else
+    if ((effective ? PL_egid : PL_gid) == 544) { /* member of Administrators? */
 #endif
        if (mode == S_IXUSR) {
            if (statbufp->st_mode & 0111 || S_ISDIR(statbufp->st_mode))


Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About