develooper Front page | perl.perl5.porters | Postings from August 2009

Re: Duplicate entries in Config_heavy.pl

Thread Previous | Thread Next
From:
Andy Dougherty
Date:
August 7, 2009 08:39
Subject:
Re: Duplicate entries in Config_heavy.pl
Message ID:
alpine.DEB.2.00.0908071126370.16188@fractal.phys.lafayette.edu
On Fri, 7 Aug 2009, H.Merijn Brand wrote:

> On Thu, 6 Aug 2009 17:05:10 -0400 (EDT), Andy Dougherty
> <doughera@lafayette.edu> wrote:
> 
> > On Thu, 6 Aug 2009, Slaven Rezic wrote:
> > 
> > > In Config_heavy.pl of my perl5.10.1-to-be installation there are some
> > > duplicates:
> > > 
> > > config_arg0='./Configure'
> > > config_arg0='./Configure'
> > 
> > [etc.]
> > 
> > That's a bug in Configure.  The line
> > 
> >     $test -f UU/cmdline.opt && $cat UU/cmdline.opt >> config.sh
> > 
> > appears twice in Configure.  I'm not sure how that snuck in.
> 
> I think this happened during my big changes to move from meta 3.0 to 3.5

Probably.  The first one comes from U/modified/Config_sh.U, and the second 
from U/modified/Oldsym.U.  We can safely delete either one.  How do you 
want to proceed?

I can directly patch Configure in blead, and Dave can cherry-pick it for 
maint.  The patch I'd recommend is below.

I can patch the metaconfig unit, but then you'd have to regenerate 
Configure and apply that patch to blead.

On a side note, I still am having trouble with the metaconfig/git 
repository.  Looking at http://perl5.git.perl.org/ shows the last commit 
as being in December, 2008.  github.com shows the same.  Is that really 
the most up-to-date version, or does something need to be pushed 
somewhere?  Or am I looking in the wrong place?


diff --git a/Configure b/Configure
index 185d6b6..c42de03 100755
--- a/Configure
+++ b/Configure
@@ -22122,7 +22122,9 @@ $startsh
 # Target system     : $myuname
 
 EOT
+: Add in command line options if available
 $test -f UU/cmdline.opt && $cat UU/cmdline.opt >> config.sh
+
 $spitshell <<EOT >>config.sh
 
 Author='$Author'
@@ -23191,9 +23193,6 @@ zcat='$zcat'
 zip='$zip'
 EOT
 
-: Add in command line options if available
-$test -f UU/cmdline.opt && $cat UU/cmdline.opt >> config.sh
-
 : add special variables
 $test -f $src/patchlevel.h && \
 awk '/^#define[ 	]+PERL_/ {printf "%s=%s\n",$2,$3}' $src/patchlevel.h >>config.sh


-- 
    Andy Dougherty		doughera@lafayette.edu

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About