develooper Front page | perl.perl5.porters | Postings from August 2009

Re: maint-5.10 CPAN very noisy

Thread Previous | Thread Next
From:
Dave Mitchell
Date:
August 5, 2009 09:28
Subject:
Re: maint-5.10 CPAN very noisy
Message ID:
20090805162828.GG13113@iabyn.com
On Wed, Aug 05, 2009 at 10:09:50AM -0400, Andy Dougherty wrote:
> Here's a tested patch implementing the relevant part of (c).  I didn't 
> touch the version number because I don't know what's the best plan there 
> (In fact, I'd be somewhat tempted to go with (a) to avoid the whole 
> modules-out-of-sync issue.)

Thanks. I applied a slightly modified version (whoops - and fogot to
credit you!) that changes both clucks, and bumps the FTP.pom version
number.


commit 039dab98824ab37144e8e9a1c62c6a4cbd4a8012
Author:     David Mitchell <davem@iabyn.com>
AuthorDate: Wed Aug 5 17:24:58 2009 +0100
Commit:     David Mitchell <davem@iabyn.com>
CommitDate: Wed Aug 5 17:24:58 2009 +0100

    The current CPAN is very noisy on download failure;
    it's showing a full perl stack trace. temporary fix for now.


Affected files ...
    
    M	lib/CPAN/FTP.pm

Differences ...

diff --git a/lib/CPAN/FTP.pm b/lib/CPAN/FTP.pm
index e4e462a..fab3d12 100644
--- a/lib/CPAN/FTP.pm
+++ b/lib/CPAN/FTP.pm
@@ -13,7 +13,7 @@ use vars qw($connect_to_internet_ok $Ua $Thesite $ThesiteURL $Themethod);
 use vars qw(
             $VERSION
 );
-$VERSION = "5.5";
+$VERSION = "5.5001";
 
 #-> sub CPAN::FTP::ftp_statistics
 # if they want to rewrite, they need to pass in a filehandle
@@ -832,9 +832,9 @@ No success, the file that lynx has downloaded is an empty file.
     } # host
     require Carp;
     if ($some_dl_success) {
-        Carp::cluck("Warning: doesn't seem we had substantial success downloading '$aslocal'. Don't know how to proceed.");
+        Carp::carp("Warning: doesn't seem we had substantial success downloading '$aslocal'. Don't know how to proceed.");
     } else {
-        Carp::cluck("Warning: no success downloading '$aslocal'. Giving up on it.");
+        Carp::carp("Warning: no success downloading '$aslocal'. Giving up on it.");
     }
     $CPAN::Frontend->mysleep(5);
     return;


-- 
Red sky at night - gerroff my land!
Red sky at morning - gerroff my land!
    -- old farmers' sayings #14

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About