Front page | perl.perl5.porters |
Postings from August 2009
Re: maint-5.10 CPAN very noisy
Thread Previous
|
Thread Next
From:
Andy Dougherty
Date:
August 5, 2009 07:10
Subject:
Re: maint-5.10 CPAN very noisy
Message ID:
alpine.DEB.2.00.0908050857270.4292@fractal.phys.lafayette.edu
On Wed, 5 Aug 2009, Dave Mitchell wrote:
> On Wed, Aug 05, 2009 at 01:44:42AM +0200, Slaven Rezic wrote:
> > Dave Mitchell <davem@iabyn.com> writes:
> >
> > > On Tue, Aug 04, 2009 at 02:53:29PM -0400, Andy Dougherty wrote:
> > >> On a clean install of main-5.10.x, CPAN is very noisy about non-fatal
> > >> failures to download files. (Subsequent attempts to use a different
> > >> download method succeed, so this is annoying, but not fatal.)
> > >>
> > It seems that the change was in
> > 0d8b5309784f490d7ae813aceed2b1fdbbfaa7a3.
>
> ie this:
>
> - } # transfer programs
> + } # download/transfer programs (DLPRG)
> } # host
> + require Carp;
> + if ($some_dl_success) {
> + Carp::cluck("Warning: doesn't seem we had substantial success downloading '$aslocal'. Don't know how to proceed.");
> + } else {
> + Carp::cluck("Warning: no success downloading '$aslocal'. Giving up on it.");
> + }
> + $CPAN::Frontend->mysleep(5);
> + return;
>
>
> So, does anyone have any opinion for 5.10.1, whether I should
> a) ship CPAN as-is (with the noisy warning)
> b) remove that segment above completely
> c) keep it, but replace the clucks with carps?
I think (c) is probably your best bet, though (a) isn't bad either. It's
annoying but not fatal. CPAN correctly goes on to try the next method and
works. Any user who encounters this problem is obviously using CPAN, and
so can easily upgrade it when a tested fix is available.
I'm suspicious of (b) because I haven't verified that this is the only
condition under which that segment can or should be called. I think the
underlying problem is higher up the logic chain, but now's not the time to
fiddle with it.
Mostly, I'm embarrassed I missed this in my previous testing of not-RC0.
Here's a tested patch implementing the relevant part of (c). I didn't
touch the version number because I don't know what's the best plan there
(In fact, I'd be somewhat tempted to go with (a) to avoid the whole
modules-out-of-sync issue.)
--- perl-5.10.x/lib/CPAN/FTP.pm 2009-07-29 14:44:33.000000000 -0400
+++ perl-5.10.x-andy/lib/CPAN/FTP.pm 2009-08-05 09:02:58.677623403 -0400
@@ -834,7 +834,7 @@
if ($some_dl_success) {
Carp::cluck("Warning: doesn't seem we had substantial success downloading '$aslocal'. Don't know how to proceed.");
} else {
- Carp::cluck("Warning: no success downloading '$aslocal'. Giving up on it.");
+ Carp::carp("Warning: no success downloading '$aslocal'. Giving up on it.");
}
$CPAN::Frontend->mysleep(5);
return;
--
Andy Dougherty doughera@lafayette.edu
Thread Previous
|
Thread Next