On Wed, Aug 05, 2009 at 01:44:42AM +0200, Slaven Rezic wrote: > Dave Mitchell <davem@iabyn.com> writes: > > > On Tue, Aug 04, 2009 at 02:53:29PM -0400, Andy Dougherty wrote: > >> On a clean install of main-5.10.x, CPAN is very noisy about non-fatal > >> failures to download files. (Subsequent attempts to use a different > >> download method succeed, so this is annoying, but not fatal.) > >> > >> The typical error message looks like this: > >> > >> cpan shell -- CPAN exploration and modules installation (v1.9402) > >> Enter 'h' for help. > >> > >> .[4mcpan[1]> .[mm PPI > >> CPAN: Storable loaded ok (v2.20) > >> Warning: no success downloading '/export/home/doughera/.cpan/sources/authors/01mailrc.txt.gz.tmp21918'. Giving up on it. at /export/home/doughera/my/perl/lib/5.10.1/CPAN/FTP.pm line 837 > >> CPAN::FTP::hostdlhard('CPAN::FTP', 'ARRAY(0x85f3fa0)', 'authors/01mailrc.txt.gz', '/export/home/doughera/.cpan/sources/authors/01mailrc.txt.gz.t...', 'HASH(0x8b713d8)') called at /export/home/doughera/my/perl/lib/5.10.1/CPAN/FTP.pm line 515 > > [snip] > >> Does this look familiar to anyone? (This was present in the "not RC0" > >> snapshot, but somehow I missed it.) > > > > Its also present in blead, but not 5.10.0. It's generated by Carp::cluck() > > in CPAN::FTP, a module that isn't present in 5.10.0. > > The package CPAN::FTP was existent in 5.10.0, but the module wasn't. > Previously almost everything was in CPAN.pm > > > > > Andreas, can you enlighten us? > > Andreas is on vacation and probably not online before August 14 or so. > > It seems that the change was in > 0d8b5309784f490d7ae813aceed2b1fdbbfaa7a3. ie this: - } # transfer programs + } # download/transfer programs (DLPRG) } # host + require Carp; + if ($some_dl_success) { + Carp::cluck("Warning: doesn't seem we had substantial success downloading '$aslocal'. Don't know how to proceed."); + } else { + Carp::cluck("Warning: no success downloading '$aslocal'. Giving up on it."); + } + $CPAN::Frontend->mysleep(5); + return; So, does anyone have any opinion for 5.10.1, whether I should a) ship CPAN as-is (with the noisy warning) b) remove that segment above completely c) keep it, but replace the clucks with carps? -- "Procrastination grows to fill the available time" -- Mitchell's corollary to Parkinson's LawThread Previous | Thread Next