develooper Front page | perl.perl5.porters | Postings from July 2009

Re: [PATCH] Add MANIFEST sort test

Thread Previous | Thread Next
From:
H.Merijn Brand
Date:
July 29, 2009 13:56
Subject:
Re: [PATCH] Add MANIFEST sort test
Message ID:
20090729225536.08b1fdfd@pc09.procura.nl
On Wed, 29 Jul 2009 16:48:26 -0400, Jesse Vincent <jesse@fsck.com>
wrote:

> On Wed 29.Jul'09 at 22:26:15 +0200, H.Merijn Brand wrote:
> > On Wed, 29 Jul 2009 13:52:24 -0400, "Jerry D. Hedden"
> > <jdhedden@cpan.org> wrote:
> > 
> > > The attached patch adds a test to t/lib/manifest.t to check that the
> > > MANIFEST file is properly sorted.  (And guess what?  It isn't.)
> > 
> > Why rely on external sort, where perl has a more reliable sort itself?
> 
> Well, we _are_ using the external sort to do the sorting, rather than
> Perl's built sort.

That is what I meant. Why?
There have been several occasions in the past few month where I fell
back to perl's sort instead of system sort because - even with a forced
LC_ALL and LANG - system sort gave me different results on different
machines where perl's sort works `as expected' (TM)

> I've been in the process of working over the releng docs. 

I saw ++ to you!

> Porting/manicheck should definitely be absorbed into this testfile.
> 
> It might be worth having the failure mode telling the user to run
> "make manisort" to actually fix the problem, too. 

-- 
H.Merijn Brand  http://tux.nl      Perl Monger  http://amsterdam.pm.org/
using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,
11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3.
http://mirrors.develooper.com/hpux/           http://www.test-smoke.org/
http://qa.perl.org      http://www.goldmark.org/jeff/stupid-disclaimers/

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About