develooper Front page | perl.perl5.porters | Postings from July 2009

Re: [PATCH] Add MANIFEST sort test

Thread Previous | Thread Next
From:
Jesse Vincent
Date:
July 29, 2009 13:48
Subject:
Re: [PATCH] Add MANIFEST sort test
Message ID:
20090729204826.GO472@17h-2.local



On Wed 29.Jul'09 at 22:26:15 +0200, H.Merijn Brand wrote:
> On Wed, 29 Jul 2009 13:52:24 -0400, "Jerry D. Hedden"
> <jdhedden@cpan.org> wrote:
> 
> > The attached patch adds a test to t/lib/manifest.t to check that the
> > MANIFEST file is properly sorted.  (And guess what?  It isn't.)
> 
> Why rely on external sort, where perl has a more reliable sort itself?

Well, we _are_ using the external sort to do the sorting, rather than
Perl's built sort.

I've been in the process of working over the releng docs. 

Porting/manicheck should definitely be absorbed into this testfile.

It might be worth having the failure mode telling the user to run
"make manisort" to actually fix the problem, too. 

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About