Front page | perl.perl5.porters |
Postings from July 2009
2009/7/26 Michael G Schwern <schwern@pobox.com>: > demerphq wrote: >> Actually, ive been meaning to chase something related to that, in that >> some time back I did some slicing and dicing of some of the test files >> in the core that are shared by EUMM and EUI to make it easier to >> construct the EUMM and EUI from the core files properly, but it seems >> maybe these changes were not pushed to EUMM even though Schwern was >> advised of them, and I think later on they were overwritten by >> somebody doing a naive "copy EUMM" into core. So its actually possible >> that EUI isnt being properly tested in core anymore. I need to dig >> further today. > > I decided against taking it upstream as it made basic.t, the most complicated > test, even more complicated. The plan for core moving forward, as far as I'm > concerned, is to put all dual-life modules into their own ext/ directory and > stop scattering tests around lib/ and then the problem of clashing goes away. > This was done back in March but held up pending 5.10.1. > http://github.com/schwern/perl/tree/ext_tests Did I miss you telling me this? Im actually a little annoyed about this, as basic.t has tests of EUI, so splitting it into ext doesnt solve anything. It still means that patches from EUMM to EUI tests have to be cross ported to EUI, and vice versa, and the files dont "line up" so to speak. With the patch I did, this burden was eliminated. So im really not at all sure what "complexity" it is that you have avoided here, as far as I can see you have just made it more difficult to maintain both packages and core. Because now, everytime somebody updates core from either package you have to be careful not to stomp on the files from the opposite. So actually, this rejection was a net loss for us all. Sorry. cheers, Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"Thread Previous | Thread Next