Front page | perl.perl5.porters |
Postings from July 2009
2009/7/26 Craig A. Berry <craig.a.berry@gmail.com>: > On Sun, Jul 26, 2009 at 4:48 AM, demerphq<demerphq@gmail.com> wrote: > >> some time back I did some slicing and dicing of some of the test files >> in the core that are shared by EUMM and EUI to make it easier to >> construct the EUMM and EUI from the core files properly, but it seems >> maybe these changes were not pushed to EUMM even though Schwern was >> advised of them, and I think later on they were overwritten by >> somebody doing a naive "copy EUMM" into core. So its actually possible >> that EUI isnt being properly tested in core anymore. I need to dig >> further today. > > I've been wondering whether something was up in this area. The "copy > EUMM" you are referring to was probably this: > > http://perl5.git.perl.org/perl.git/commitdiff/b6d6132c1554383190492215dd1da143d1d564ef > > which was just a few days before your latest update of > ExtUtils::Install. You may or may not have noticed that Tru64 is > having trouble with the EU::Install tests: > > http://www.nntp.perl.org/group/perl.daily-build.reports/2009/07/msg71551.html > > and on VMS I occasionally (but not consistently) get > > lib/ExtUtils/t/Installapi2....................................FAILED > at test 15 > lib/ExtUtils/t/Install........................................FAILED > at test 15 > > which I originally thought was your recent update of EU::Install but > am now more suspicious of the the test infrastructure shared with > EUMM. Hmm, no i dont think this is it. The changes im thinking of were to basic.t I think it was 1487aac67a72b9f87b24113f65b4d878401bee33, which appears to have stomped on the changes that were made in 4954abf77fcbac122d63699b1b3921b4d44d4570 that split basic.t into basic.pl and basic_finish.pl and then two separate basic.t's one that would be used by EUI, and would NOT be in the core, and one used by EUMM and that would be in the core. It looks like, probably due to me not following through properly, that this change didnt go upstream to EUMM proper, and thus Nicholas (probably accidentally) stomped on the change when he upgraded to EUMM 6.49_01. Which then meant that changes that might have gone in to basic_finish.pl from the EUI package wouldnt end up being executed, as basic.pl/basic_finish.pl are no longer used. Its a pity this happened, as the whole idea of the changes in 4954abf were meant to make it possible to have identical tests in EUMM/EUI and Core, but somehow it backfired and made things worse. :-( cheers, Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"Thread Previous | Thread Next