develooper Front page | perl.perl5.porters | Postings from July 2009

[PATCH-tests] Tests for commit1375cf1cf2085f851bb176047d5e60248542f555 [perl #66112]

Thread Next
From:
Bram
Date:
July 25, 2009 13:27
Subject:
[PATCH-tests] Tests for commit1375cf1cf2085f851bb176047d5e60248542f555 [perl #66112]
Message ID:
20090725222744.8sg6b09ggkgwo8sk@horde.wizbit.be
Citeren Nicholas Clark <nick@ccl4.org>:

> In perl.git, the branch blead has been updated
>
> <http://perl5.git.perl.org/perl.git/commitdiff/1375cf1cf2085f851bb176047d5e60248542f555?hp=8ad0ee873ef9de8fbabd98634b89c1b6aca1233a>
>
> - Log -----------------------------------------------------------------
> commit 1375cf1cf2085f851bb176047d5e60248542f555
> Author: Nicholas Clark <nick@ccl4.org>
> Date:   Sat Jul 25 17:04:29 2009 +0100
>
>     When resetting our children, wipe out the isa cache too.
>
>     (Fix to change 34354, which introduced a cached hash to make ->isa O(1))
>
> M	mro.c
>


Patch attached.

Without Nicholas change:

ok 118 - modify @ISA in isa (RT66112::T1 isa RT66112::C)
ok 119 - modify @ISA in isa (RT66112::T2 isa RT66112::B)
not ok 120 - modify @ISA in isa (RT66112::T3 isa RT66112::A)
ok 121 - modify @ISA in isa (RT66112::T4 isa RT66112::E)
not ok 122 - modify @ISA in isa (RT66112::T5 not isa RT66112::D)
not ok 123 - modify @ISA in isa (RT66112::T6 isa RT66112::A)
# Failed at op/universal.t line 296
# Failed at op/universal.t line 304
# Failed at op/universal.t line 308
Failed 3/123 subtests

Test Summary Report
-------------------
op/universal.t (Wstat: 0 Tests: 123 Failed: 3)
   Failed tests:  120, 122-123
Files=1, Tests=123,  0 wallclock secs ( 0.04 usr  0.01 sys +  0.03  
cusr  0.00 csys =  0.08 CPU)
Result: FAIL
Failed 1/1 test programs. 3/123 subtests failed.



With Nicholas change:

ok 118 - modify @ISA in isa (RT66112::T1 isa RT66112::C)
ok 119 - modify @ISA in isa (RT66112::T2 isa RT66112::B)
ok 120 - modify @ISA in isa (RT66112::T3 isa RT66112::A)
ok 121 - modify @ISA in isa (RT66112::T4 isa RT66112::E)
ok 122 - modify @ISA in isa (RT66112::T5 not isa RT66112::D)
ok 123 - modify @ISA in isa (RT66112::T6 isa RT66112::A)
ok
All tests successful.
Files=1, Tests=123,  0 wallclock secs ( 0.04 usr  0.01 sys +  0.03  
cusr  0.00 csys =  0.08 CPU)
Result: PASS



Best regards,

Bram


Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About