On Tue, Jul 07, 2009 at 11:18:49PM +0100, Tom Hukins wrote: > On Wed, Jul 08, 2009 at 12:09:41AM +0200, Vincent Pit wrote: > > got a few failures : Devel::Cover, Math::Pari, PerlMagick, JSON::DWIW. I > > can't say if they are regressions from 5.10.0 yet. > > Devel::Cover has failed against maint-5.10 for a few months now. I > got in touch with Paul, its author, to let him know about this. The > module's tests fail due to something different that Perl does with its > code internally (sorry, I don't understand the details) but the module > itself works fine. Yes, a test is failing because the optree has changed somewhat and the Deparse code I nicked doesn't know about that. I assume that Deparse itself has been updated so I just need to nick the updated code. (There's that word again - "just".) Of course the real solution is to refactor Deparse so I don't need to nick its code, I can just call it. I don't have time for that. I'm not sure whether I have time to fix up Devel::Cover properly before Dave gets 5.10.1 out of the door, but I'll make sure that there's a Devel::Cover available that doesn't fail its tests before that happens, one way or another. The failure mode is that "$a && $b" is displayed as "do { $b if $a }", or something very similar. -- Paul Johnson - paul@pjcj.net http://www.pjcj.netThread Previous | Thread Next