develooper Front page | perl.perl5.porters | Postings from June 2009

Re: [PATCH] re building perltoc.pod

Thread Previous | Thread Next
Nicholas Clark
June 29, 2009 07:08
Re: [PATCH] re building perltoc.pod
Message ID:
On Wed, Apr 22, 2009 at 06:53:51PM +0100, Nicholas Clark wrote:
> On Wed, Apr 22, 2009 at 06:45:55PM +0100, Robin Barker wrote:
> > The recent patch to build perltoc.pod throws up some errors and warnings.
> > 
> > On a clean build, the call to pod/buildtoc does not find File::Glob because it has not been built yet, 
> > I think the references to 'ext' in the Makefile should be '$(ext)'
> We think so too. That's already been fixed by
> > Also (from a clean build), the call to pod/buildtoc warns that perltoc.pod is missing, when that is the file it is building.
> > I have added some extra logic to not warn about missing files when those files are the ones being build. 
> Thanks for spotting and proposing a fix for this. However, I'm not sure if it's
> the most elegant solution. I *think* (but have not verified this) that
> pod/buildtoc can (and therefore should) be split into two scripts. One is
> pod/buildtoc, and (just) builds pod/perlpod.pod. The other is all the other
> functionality.

I still can't spot a clean way to do this, and I'm not sure if it will fix
the problem of the spurious warning anyway, so somewhat belatedly I've applied
your patch as 78fb583c0588329906d767eceec4c92fe2774964. Thanks.

Nicholas Clark

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About