develooper Front page | perl.perl5.porters | Postings from June 2009

Re: patch submission(symbian/sdk.pl)

Thread Previous | Thread Next
From:
H.Merijn Brand
Date:
June 27, 2009 13:02
Subject:
Re: patch submission(symbian/sdk.pl)
Message ID:
20090627220206.19978d3c@pc09.procura.nl
On Sat, 27 Jun 2009 13:44:38 -0500, "Craig A. Berry"
<craig.a.berry@gmail.com> wrote:

> On Sat, Jun 27, 2009 at 12:23 PM, Dave Mitchell<davem@iabyn.com> wrote:
> > On Sat, Jun 27, 2009 at 11:05:25AM +0200, H.Merijn Brand wrote:
> 
> >> etc. They won't apply with git-am
> >
> > Are you sure they're errors and not just warnings?
> >
> > git am shouldn't be refusing to apply a patch that happens to result in a
> > line with trailing whitespace!
> 
> I don't think it does.  The default behavior (equivalent to
> --whitespace=warn) is that it reports "whitespace errors" but commits
> the patch anyway (assuming the trailing whitespace is the only
> objection it has).  IMO it really shouldn't use the word "error" when
> complaining about it because that suggests the apply operation failed.
> 
> In other words, by default, "whitespace errors" is really just an
> informational message which means, roughly, "Linus has a pet peeve
> about trailing whitespace and you should too."  Thanks, but I have one
> or two more important things to worry about.

In this case I got the warnings, but also a fail. The patch would not
apply. It however *did* apply when using --whitespace=fix

-- 
H.Merijn Brand  http://tux.nl      Perl Monger  http://amsterdam.pm.org/
using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,
11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3.
http://mirrors.develooper.com/hpux/           http://www.test-smoke.org/
http://qa.perl.org      http://www.goldmark.org/jeff/stupid-disclaimers/

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About