develooper Front page | perl.perl5.porters | Postings from June 2009

Re: patch submission(symbian/sdk.pl)

Thread Previous | Thread Next
From:
H.Merijn Brand
Date:
June 27, 2009 02:05
Subject:
Re: patch submission(symbian/sdk.pl)
Message ID:
20090627110525.5d4d5833@pc09.procura.nl
On Sat, 27 Jun 2009 00:12:12 -0400 (EDT), Adam Russell
<arussell@cs.uml.edu> wrote:

> I have updated the symbian port to the point where I can build
> the interpreter successfully and get it to actually run on a symbian 
> device.
> This is yet another patch which has been a part of that effort. In this 
> case this file needed to be updated to include options for the most recent 
> Symbian SDKs since this port hasn't gotten much attention in quite a few 
> years!
> I believe I have fixed the line ending weirdness seen in the last patch I 
> submitted. The trick was the --ignore-space-at-eol flag for the
> git format-patch
> command.
> This patch is the worl of myself and Oscar Villalon whom I have credited 
> also in the patch file.
> Best Regards,
> Adam Russell

Hmm, do I have to enable a whitespace `fixer' for your patches? In this
mail it looked rather ok, but

Applying: patch submission(symbian/sdk.pl)
/pro/3gl/CPAN/perl-git/.git/rebase-apply/patch:13: trailing whitespace.
# Configuration for S60 5th Edition SDK v0.9
/pro/3gl/CPAN/perl-git/.git/rebase-apply/patch:14: trailing whitespace.
$SYMBIAN_VERSION = '9.4'; 
/pro/3gl/CPAN/perl-git/.git/rebase-apply/patch:15: trailing whitespace.
$SDK_NAME = 'S60_5th_Edition_SDK'; 
/pro/3gl/CPAN/perl-git/.git/rebase-apply/patch:16: trailing whitespace.
$WIN = 'winscw'; 
/pro/3gl/CPAN/perl-git/.git/rebase-apply/patch:17: trailing whitespace.
$ENV{WIN} = $WIN; 

etc. They won't apply with git-am

-- 
H.Merijn Brand  http://tux.nl      Perl Monger  http://amsterdam.pm.org/
using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,
11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3.
http://mirrors.develooper.com/hpux/           http://www.test-smoke.org/
http://qa.perl.org      http://www.goldmark.org/jeff/stupid-disclaimers/

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About