develooper Front page | perl.perl5.porters | Postings from April 2009

Re: [PATCH] re building perltoc.pod

Thread Previous | Thread Next
From:
Nicholas Clark
Date:
April 22, 2009 10:54
Subject:
Re: [PATCH] re building perltoc.pod
Message ID:
20090422175351.GQ71149@plum.flirble.org
On Wed, Apr 22, 2009 at 06:45:55PM +0100, Robin Barker wrote:
> The recent patch to build perltoc.pod throws up some errors and warnings.
> 
> On a clean build, the call to pod/buildtoc does not find File::Glob because it has not been built yet, 
> I think the references to 'ext' in the Makefile should be '$(ext)'

We think so too. That's already been fixed by
http://perl5.git.perl.org/perl.git/commit/3e21d4f03715f95b91263d6985791a97f088a54e

> Also (from a clean build), the call to pod/buildtoc warns that perltoc.pod is missing, when that is the file it is building.
> I have added some extra logic to not warn about missing files when those files are the ones being build. 

Thanks for spotting and proposing a fix for this. However, I'm not sure if it's
the most elegant solution. I *think* (but have not verified this) that
pod/buildtoc can (and therefore should) be split into two scripts. One is
pod/buildtoc, and (just) builds pod/perlpod.pod. The other is all the other
functionality.

This will work if building everything but perltoc.pod doesn't need any of the
results of the "# Find all the mdoules" logic, and work very well if building
perltoc.pod doesn't need any part of pod.lst

Nicholas Clark

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About