develooper Front page | perl.perl5.porters | Postings from February 2009

[BUG] Re: [perl.git] branch blead, updated. GitLive-blead-579-g38fddf8

Thread Next
From:
Jerry D. Hedden
Date:
February 10, 2009 08:10
Subject:
[BUG] Re: [perl.git] branch blead, updated. GitLive-blead-579-g38fddf8
Message ID:
1ff86f510902100810w7ccbf934g5b6746e34c833204@mail.gmail.com
On Tue, Feb 10, 2009 at 9:58 AM, H.Merijn Brand <h.m.brand@xs4all.nl> wrote:
> In perl.git, the branch blead has been updated
>
> <http://perl5.git.perl.org/perl.git/commitdiff/38fddf8b5d4021b3807b4f9658a4689b671308a1?hp=6ed34527c34dc05915ae3caa982e733d04613a1e>
>
> - Log -----------------------------------------------------------------
> commit 38fddf8b5d4021b3807b4f9658a4689b671308a1
> Author: H.Merijn Brand <h.m.brand@xs4all.nl>
> Date:   Tue Feb 10 15:58:14 2009 +0100
>
>    Restore old behavior for perl builds with (still) unflattened ext/.
>
>    Backported assorted changes and regenerated Configure
> -----------------------------------------------------------------------
>
> Summary of changes:
>  Configure   |   40 ++++++++++++++++++++++++++++++++++------
>  config_h.SH |   40 ++++++++++++++++++++--------------------
>  2 files changed, 54 insertions(+), 26 deletions(-)
>  mode change 100644 => 100755 config_h.SH
>
> diff --git a/Configure b/Configure
> index a549650..928b843 100755
> --- a/Configure
> +++ b/Configure
> @@ -25,7 +25,7 @@
>
>  # $Id: Head.U 6 2006-08-25 22:21:46Z rmanfredi $
>  #
> -# Generated on Mon Jan 19 16:46:57 CET 2009 [metaconfig 3.5 PL0]
> +# Generated on Tue Feb 10 15:55:56 CET 2009 [metaconfig 3.5 PL0]
>  # (with additional metaconfig patches by perlbug@perl.org)
>
>  cat >c1$$ <<EOF
> @@ -21612,7 +21612,8 @@ nonxs_extensions=''
>  : some additional extensions into the source tree and expect them
>  : to be built.
>
> -: Function to find available extensions, ignoring DynaLoader
> +: Function to recursively find available extensions, ignoring DynaLoader
> +: NOTE: recursion limit of 10 to prevent runaway in case of symlink madness
>  find_extensions='
>     for xxx in *; do
>        case "$xxx" in
> @@ -21620,10 +21621,27 @@ find_extensions='
>            *)
>            this_ext=`echo $xxx | $sed -e s/-/\\\//g`;
>            leaf=`echo $xxx | $sed -e s/.*-//`;
> -           if $test -f $xxx/$leaf.xs -o -f $xxx/$leaf.c; then
> -               known_extensions="$known_extensions $this_ext";
> -           elif $test -d $xxx; then
> -               nonxs_extensions="$nonxs_extensions $this_ext";
> +           if $test -d File-Glob; then
> +               : All ext/ flattened

Bad syntax.  This is causing Configure to mess up:

    Looking for extensions...
    ./Configure: eval: line 21648: syntax error near unexpected token `then'
    ./Configure: eval: line 21648: `for xxx in *; do case "$xxx" in
DynaLoader|dynaload) ;; *) this_ext=`echo $xxx | $sed -e s/-/\\\//g`;
leaf=`echo $xxx | $sed -e s/.*-//`; if $test -d File-Glob; then : All
ext/ flattened if $test -f $xxx/$leaf.xs -o -f $xxx/$leaf.c; then
known_extensions="$known_extensions $this_ext"; elif $test -d $xxx;
then nonxs_extensions="$nonxs_extensions $this_ext"; fi else if $test
-f $xxx/$leaf.xs -o -f $xxx/$leaf.c; then
known_extensions="$known_extensions $1$this_ext"; elif $test -f
$xxx/Makefile.PL; then nonxs_extensions="$nonxs_extensions
$1$this_ext"; else if $test -d $xxx -a $# -lt 10; then set $1$xxx/ $*;
cd "$xxx"; eval $find_extensions; cd ..; shift; fi; fi; fi ;; esac;
done'

Should that colon be a hash (#)?


> +               if $test -f $xxx/$leaf.xs -o -f $xxx/$leaf.c; then
> +                   known_extensions="$known_extensions $this_ext";
> +               elif $test -d $xxx; then
> +                   nonxs_extensions="$nonxs_extensions $this_ext";
> +               fi
> +           else

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About