develooper Front page | perl.perl5.porters | Postings from December 2008

Re: [PATCH] checkpods -> podchecker

Thread Previous | Thread Next
From:
Rafael Garcia-Suarez
Date:
December 25, 2008 11:04
Subject:
Re: [PATCH] checkpods -> podchecker
Message ID:
b77c1dce0812251102h7026b29di39efdcac0a1ae445@mail.gmail.com
2008/10/29 Alex Vandiver <alexmv@bestpractical.com>:
> Heya,
> perltodo says:
>        F<pod/checkpods.PL> (and C<make check> in the F<pod/>
>        subdirectory) implements a very basic check for pod files, but
>        the errors it discovers aren't found by podchecker. Add this
>        check to podchecker, get rid of checkpods and have C<make check>
>        use podchecker.
>
> I glanced at this, and it seems to be rather straightforard -- the only
> errors that checkpods looks for are that there's a blank line before POD
> directives, which is already a subset of what podchecker does.  Attached
> are a number of patches relevant to fixing this TODO; the first four
> apply to perl itself, the last two to Pod::Checker.

Thanks, all patches applied, except parts of #2 -- I amended the
perlfunc changes and apply the perlfaq changes separately, since the
perlfaq master is in svn elsewhere (for the moment)

> 1. This changes all occurrences of checkpods to using podchecker
> instead.
>
> 2. This cleans up various parts of the core POD to pass the now stricter
> podchecker.
>
> 3. Remove all mention of checkpods, and checkpods itself.
>
> 4. Remove the compelted perltodo entry.
>
> 5. Indented blank lines in the middle of a verbatim block currently
> warn.  As having blank lines in the middle of your example code isn't
> uncommon, this patch makes such a circumstance not a warnable offense.
>
> 6. Pod::Checker thinks that "64bit" is a number, and warns about its
> presence in the middle of a set of =item's with strings.  This patch
> backs down the hair-trigger on "numeric" =item detection.
>
> This is also my first foray into generating patches off of the perl git
> repository, and into using git in general -- suggestions and nitpicks on
> git usage would be appreciated.
>  - Alex
>



-- 
'Do you know what they called a sausage-in-a-bun in Quirm?' said Mr Pin,
as the two walked away. --- 'No?' said Mr Tulip. --- 'They called it "le
sausage-in-le-bun".'                       -- Terry Pratchett, The Truth

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About