develooper Front page | perl.perl5.porters | Postings from December 2008

RE: [perl #61492] ExtUtils::MM_Win32 should not generate "mt"command when CRT is statically linked

Thread Previous | Thread Next
From:
Sam Vilain
Date:
December 20, 2008 16:07
Subject:
RE: [perl #61492] ExtUtils::MM_Win32 should not generate "mt"command when CRT is statically linked
Message ID:
1229727434.6418.25.camel@maia.lan
On Fri, 2008-12-19 at 17:43 +0000, Steve Hay wrote:
> Thanks, applied as 4adc95e616bac7eea015e9e47e439b063c1132d5.

Just to nitpick this change; the body of the commit is this:

Subject: RE: [perl #61492] ExtUtils::MM_Win32 should not generate "mt"
command when CRT is statically linked
From: "Jan Dubois" <jand@activestate.com>
Date: Fri, 19 Dec 2008 03:02:45 -0800
Message-ID: <00f901c961c9$5321e1e0$f965a5a0$@com>

Ideally the "From" and "Date" headers should go into the "Author" fields
of the commit.  This happens automatically if you save the e-mail with
the patch in it, and apply it using 'git-am'.  Or you could change it
after committing (before pushing) using 'git commit --amend
--author="XXX"'.

Also, the general practice is to separate the one-line description of
the change from the first stanza of information about the change.  Ie,
the first line of the commit message is implied to be the Subject:, and
after the first line feed comes the long description of the commit.  Eg,
a summary of why the change was required - perhaps an appropriate
comment lifted from the list message.  And after that, the other
RFC822-style headers which are appropriate for the commit can be listed.

I realise that including a summary isn't the current practice, but it
does add value and if you look at the "timinator"-era and Chip's
history, I've actually gone and thrown (trimmed) p5p message bodies as
the long description to save the maintainer a visit to the list
archive. 

Sam.


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About