Re: [PATCH] standardize save/restore of errno & vaxc$errno

On Fri, Dec 5, 2008 at 3:32 PM, Chip Salzenberg <chip@pobox.com> wrote:
> On Fri, Dec 05, 2008 at 06:17:44PM -0000, Steve Hay wrote:
>> Thanks, applied as 35018.
>
> A followup: You may want to add this patch too.  It silences a
> false-positive gcc warning that only shows up with optimization.
>
> diff --git a/util.c b/util.c
> index 6af4be3..c4fa794 100644
> --- a/util.c
> +++ b/util.c
> @@ -2875,8 +2875,8 @@ Perl_my_pclose(pTHX_ PerlIO *ptr)
>        return my_syspclose(ptr);
>     }
>  #endif
> -    if ((close_failed = (PerlIO_close(ptr) == EOF)))
> -       SAVE_ERRNO;
> +    close_failed = (PerlIO_close(ptr) == EOF);
> +    SAVE_ERRNO;

Is that line supposed to be

    if (close_failed) SAVE_ERRNO;

?

Or do you now want to save errno regardless of whether the close failed?

>  #ifdef UTS
>     if(PerlProc_kill(pid, 0) < 0) { return(pid); }   /* HOM 12/23/91 */
>  #endif

• [PATCH] standardize save/restore of errno & vaxc$errno by Chip Salzenberg
• RE: [PATCH] standardize save/restore of errno & vaxc$errno by Steve Hay
• Re: [PATCH] standardize save/restore of errno & vaxc$errno by Chip Salzenberg
• RE: [PATCH] standardize save/restore of errno & vaxc$errno by Steve Hay
• Re: [PATCH] standardize save/restore of errno & vaxc$errno by Craig A. Berry
• Re: [PATCH] standardize save/restore of errno & vaxc$errno by Chip Salzenberg
• Re: [PATCH] standardize save/restore of errno & vaxc$errno by Chip Salzenberg
• Re: [PATCH] standardize save/restore of errno & vaxc$errno by Steve Peters
• RE: [PATCH] standardize save/restore of errno & vaxc$errno by Steve Hay
• Re: [PATCH] standardize save/restore of errno & vaxc$errno by Chip Salzenberg