develooper Front page | perl.perl5.porters | Postings from December 2008

RE: [PATCH] standardize save/restore of errno & vaxc$errno

Thread Previous | Thread Next
Steve Hay
December 5, 2008 10:17
RE: [PATCH] standardize save/restore of errno & vaxc$errno
Message ID:
Chip Salzenberg wrote:
> The fix for bug #1154 will require saving and restoring errno, and
> I've 
> found that this basic and nonportable operation had not been
> standardized. 
> So here's a patch to do that.
> Win32 note: my_pclose() was saving the result of GetLastError(), but
> was 
> not using it; in particular it was not calling SetLastError(), which
> one 
> might have expected it to do.  Would a Win32 expert care to weigh in?
> VMS note: I have no VMS system, and this patch could break something
> if 
> vaxc$errno doesn't work as documented online and/or I haven't grokked
> it 
> properly.  Some smoke testing would be appropriate.

Thanks, applied as 35018.

(It does look like my_pclose() should have called SetLastError(), but
perhaps there should be lots of other GetLastError()/SetLastError()
pairs scattered around too so this one probably isn't worth worrying
about on its own.)

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About