develooper Front page | perl.perl5.porters | Postings from November 2008

Re: Change 34940: setenv_getix() is not used anywhere other than util.c (and the "special

From:
Jerry D. Hedden
Date:
November 28, 2008 11:24
Subject:
Re: Change 34940: setenv_getix() is not used anywhere other than util.c (and the "special
Message ID:
1ff86f510811281124r28880119sfd1558fde818daf9@mail.gmail.com
This change causes the following build warning under Cygwin:

	  CCCMD =  gcc -DPERL_CORE -c -DPERL_PATCHNUM=34950
-DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__ -DNO_MATHOMS
-fno-strict-aliasing -pipe  -Os -pipe -funit-at-a-time -march=pentium4
-mfpmath=sse -mieee-fp -mmmx -msse -msse2 -Wall -W -Wextra
-Wdeclaration-after-statement -Wendif-labels
util.c:1779: warning: 'S_setenv_getix' defined but not used

(Sorry no patch from me.  I tried to figure out a good way
to fix it, but it looks really messy.)

> Change 34940 by nicholas@nicholas-saigo on 2008/11/26 23:20:31
>
>        setenv_getix() is not used anywhere other than util.c (and the "special
>        biologist word for stable" Msql-Mysql-modules-1.2219) so make it
>        static.
>
> Affected files ...
>
> ... //depot/perl/embed.fnc#649 edit
> ... //depot/perl/embed.h#786 edit
> ... //depot/perl/proto.h#983 edit
> ... //depot/perl/util.c#671 edit
>
> Differences ...
...
> ==== //depot/perl/util.c#671 (text) ====
> Index: perl/util.c
> --- perl/util.c#670~34934~      2008-11-26 14:04:01.000000000 -0800
> +++ perl/util.c 2008-11-26 15:20:31.000000000 -0800
> @@ -1774,8 +1774,8 @@
>  #endif /* WIN32 || NETWARE */
>
>  #ifndef PERL_MICRO
> -I32
> -Perl_setenv_getix(pTHX_ const char *nam)
> +static I32
> +S_setenv_getix(pTHX_ const char *nam)
>  {
>     register I32 i;
>     register const I32 len = strlen(nam);
> End of Patch.



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About