RE: [PATCH] standardize save/restore of errno & vaxc$errno

Steve Peters wrote:
> After I applied this patch locally, the following happened...
> 
> ../ext/PerlIO/t/ioleaks                                      (Wstat: 0
> Tests: 12 Failed: 0)
>   TODO passed:   1, 4, 7-12
> ../lib/Attribute/Handlers/t/linerep                          (Wstat: 0
> Tests: 18 Failed: 0)
>   TODO passed:   16
> 
> I'll try a couple of other operating systems to see for certain.

I've been getting them for a while on Win32 already, e.g. see:

http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2008-11/msg00720.
html

(The smoke only seems to (erroneously) show them if soemthing else
failed as well. Something like the following stops it, but it's only a
quick hack and there are other cases that parse the Test Summary Report
that may also need changing:

--- Smoker.pm.orig	2008-08-09 01:55:08.000000000 +0100
+++ Smoker.pm	2008-11-26 13:32:27.939110900 +0000
@@ -704,6 +704,11 @@
             push @failed, "$ntest${dots}FAILED\n";
             next;
         }
+
+        if ( $line =~ /^  TODO passed:/ ) {
+            pop @failed;
+            next;
+        }
     
         my( $failed ) = $line =~ /$harness3_re/x;
         if ( $failed ) {
End of Patch.
)

• [PATCH] standardize save/restore of errno & vaxc$errno by Chip Salzenberg
• RE: [PATCH] standardize save/restore of errno & vaxc$errno by Steve Hay
• Re: [PATCH] standardize save/restore of errno & vaxc$errno by Chip Salzenberg
• RE: [PATCH] standardize save/restore of errno & vaxc$errno by Steve Hay
• Re: [PATCH] standardize save/restore of errno & vaxc$errno by Craig A. Berry
• Re: [PATCH] standardize save/restore of errno & vaxc$errno by Chip Salzenberg
• Re: [PATCH] standardize save/restore of errno & vaxc$errno by Chip Salzenberg
• Re: [PATCH] standardize save/restore of errno & vaxc$errno by Steve Peters
• RE: [PATCH] standardize save/restore of errno & vaxc$errno by Steve Hay
• Re: [PATCH] standardize save/restore of errno & vaxc$errno by Chip Salzenberg