> ... which also means that it should probably not be public, if we > follow the logic that the optree construction should not be public; > Devel::BeginLift is already copying parts of op.c to do its magic. > > But isn't the optree construction already kind of public through the pluggable check functions ? They can alter it by replacing ops as they are created. scalar*() are definitely private. From where it's used, linklist() is better being private to. Which happens to be good, since they are now :) > To be consistent that would mean that Perl_peep() becomes static S_peep(). > Which, at least, will cause optimizer.xs to fail to link. > If peep just does local optree optimizations, then I think it could also be made hookable à la optimizer.xs.Thread Previous | Thread Next