2008/11/26 Rafael Garcia-Suarez <rgarciasuarez@gmail.com>: > 2008/11/26 Nicholas Clark <nick@ccl4.org>: >> On Wed, Nov 26, 2008 at 10:35:02AM +0000, Nicholas Clark wrote: >>> On Mon, Nov 24, 2008 at 04:36:01PM +0100, Rafael Garcia-Suarez wrote: >>> > 2008/11/24 Nicholas Clark <nick@ccl4.org>: >>> >>> > > 3: Perl_linklist() >>> > >>> > On one hand, this method could be made static. >>> > On the other hand, that's a nice way to walk an optree. And the interface >>> > is so simple and generic that it can survive any internal change :) >>> >>> >>> Well, it's essentially unchanged since revision 1, so it seems safe enough >>> to expose. What's the best way to document it? Right now, the entire >>> documentation is /* establish postfix order */ > > Hmm. After compilation, that only returns op_next, the next op to be > executed. During compilation, if op_next isn't set yet, it figures out > which op comes next and stores it in op_next. ... which also means that it should probably not be public, if we follow the logic that the optree construction should not be public; Devel::BeginLift is already copying parts of op.c to do its magic.Thread Previous | Thread Next