Front page | perl.perl5.porters |
Postings from November 2008
Re: 5.8.9 RC1
From: Nicholas Clark
November 16, 2008 09:21
Re: 5.8.9 RC1
Message ID: 20081116172109.GI49335@plum.flirble.org
On Sun, Nov 16, 2008 at 02:16:18PM +0000, Nicholas Clark wrote:
> On Sun, Nov 16, 2008 at 02:22:22PM +0100, Andreas J. Koenig wrote:
> > >>>>> On Sun, 16 Nov 2008 11:07:33 +0100, Slaven Rezic <firstname.lastname@example.org> said:
> > > Unfortunately the latest revisions are not in the public git
> > > repository,
> > My binary search is running and will take another few hours. Current
> > stat is
> > searching between 34724 and 34728 (34725,34726,34727)
> > which means 34724 is OK, 34728 is not.
> You're welcome to stop it. Slaven provided enough clues to get it in one -
> change 34726 causes the regression.
> In turn, I think that the problem is in the changes to pp_ctl.c
And I applied the following, which I believe to be the correct fix.
Change 34841 by nicholas@nicholas-saigo on 2008/11/16 17:19:33
Change 34693 introduced a regression spotted by Devel::SmallProf.
Affected files ...
... //depot/maint-5.8/perl/pp_ctl.c#198 edit
==== //depot/maint-5.8/perl/pp_ctl.c#198 (text) ====
@@ -3537,7 +3537,7 @@
/* prepare to compile string */
- if (PERLDB_SAVESRC && PL_curstash != PL_debstash)
+ if ((PERLDB_LINE || PERLDB_SAVESRC) && PL_curstash != PL_debstash)