Hi all! It's been nearly a month since there was activity on this patch. Should I modify it further, or can it be applied as is? Regards, -- Shlomi Fish On Monday 25 August 2008, Shlomi Fish wrote: > On Monday 25 August 2008, Eric Wilhelm wrote: > > # from Shlomi Fish > > > > # on Sunday 24 August 2008 13:28: > > >This patch documents open "|-" and open "-|" in perlopentut. > > > > Perhaps it should follow the practice of single quoting non-interpolated > > strings like '|-' and 'fortune'? > > Fixed in my copy. > > > Also, the filehandle in a simple > > scalar $pipe does not need to be wrapped in a block when used as an > > argument to print. > > But: > > {{{{{{{{{{ > print $pipe "Hi there!\n" > }}}}}}}}}} > > is not recommended by PBP and I agree that the $pipe does not really stand > out there. > > > The error message could probably stand to contain > > $! as well. > > Fixed in my copy. > > > I find the md5sum example not very illustrative (because md5sum will > > just print the result to stdout.) What about simply restating the > > aforementioned lpr and netstat examples? > > I converted the '|-' example to "lpr". > > > Finally, should these examples be included *before* the references to > > IPC::Open2 and perlipc? > > Don't know. > > > --Eric > > New patch attached. > > Regards, > > Shlomi Fish > > > ----------------------------------------------------------------- > Shlomi Fish http://www.shlomifish.org/ > "The Human Hacking Field Guide" - http://xrl.us/bjn8q > > Shlomi, so what are you working on? Working on a new wiki about unit > testing fortunes in freecell? -- Ran Eilam ----------------------------------------------------------------- Shlomi Fish http://www.shlomifish.org/ Understand what Open Source is - http://xrl.us/bjn82 Shlomi, so what are you working on? Working on a new wiki about unit testing fortunes in freecell? -- Ran Eilam