develooper Front page | perl.perl5.porters | Postings from September 2008

Re: [perl #41572][PATCH] Subclassing CGI::Pretty dies in ->new

Thread Previous
From:
Tony Cook
Date:
September 8, 2008 15:58
Subject:
Re: [perl #41572][PATCH] Subclassing CGI::Pretty dies in ->new
Message ID:
20080908225822.GA30901@mars.tony.develop-help.com
On Mon, Sep 08, 2008 at 08:32:23PM +0100, Nicholas Clark wrote:
> Change 28568 by stevep@stevep-kirk on 2006/07/13 20:18:59
> 
> 	Subject: [PATCH] z/OS: CPAN-ized ext/ and lib/
> 	From: Jarkko Hietaniemi <jhi@iki.fi>
> 	Date: Thu, 13 Jul 2006 23:10:27 +0300
> 	Message-ID: <44B6A8B3.5070605@iki.fi>
> 
> 
> Nicholas Clark
> 
> diff -pru ../CGI.pm-3.42/t/upload.t lib/CGI/t/upload.t
> --- ../CGI.pm-3.42/t/upload.t	2008-09-08 14:52:59.000000000 +0100
> +++ lib/CGI/t/upload.t	2008-09-08 19:40:04.000000000 +0100
> @@ -7,7 +7,17 @@
>  
>  # Due to a bug in older versions of MakeMaker & Test::Harness, we must
>  # ensure the blib's are in @INC, else we might use the core CGI.pm
> -use lib qw(. ./blib/lib ./blib/arch);
> +
> +my $test_file;
> +if($ENV{PERL_CORE}) {
> +   chdir 't';
> +   @INC = '../lib';
> +   use File::Spec ();
> +   $test_file = File::Spec->catfile(qw(.. lib CGI t), "upload_post_text.txt");
> +} else {
> +   use lib qw(. ./blib/lib ./blib/arch);
> +   $test_file = "t/upload_post_text.txt";
> +}

This seems a bit strange - the use lib is going to happen at compile
time anyway, so there's no point in moving it.

Tony


Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About