Unfortunately this patch breaks the pretty.t regression tests. Exported functions, such as h1(), no longer export. I am working on fixing this now. Yesterday's patch from Renee to fix parameter processing, broke about 50% of the regression tests! Fortunately this was easy to fix. Does anyone run the regression tests before accepting patches into core? I'd appreciate it if you perl5 porters could take CGI.pm upstream fixes only from CPAN so that we are in sync. Lincoln On Wed, Aug 27, 2008 at 8:32 AM, Nicholas Clark <nick@ccl4.org> wrote: > Forwarded to Lincoln Stein. We'll apply it to core as an update from the > upstream CGI distribution. > > Nicholas Clark > > ----- Forwarded message from renee.baecker@smart-websolutions.de ----- > > Envelope-to: nick@flirble.org > Delivery-date: Wed, 27 Aug 2008 13:25:42 +0100 > Mailing-List: contact perl5-porters-help@perl.org; run by ezmlm > Delivered-To: mailing list perl5-porters@perl.org > Delivered-To: perl5-porters@perl.org > To: perl5-porters@perl.org > Subject: [perl #41572][PATCH] Subclassing CGI::Pretty dies in ->new > X-PHP-Script: rserv16.sitepush.net/poplogin/email_neu.php for > 155.56.68.221 > From: renee.baecker@smart-websolutions.de > X-Priority: 3 > Importance: Normal > X-MSMail-Priority: Normal > X-Mailer: Confixx WebMail (like SquirrelMail) > Cc: perlbug-followup@perl.org > Date: Wed, 27 Aug 2008 14:25:25 +0200 (CEST) > > Attached is a small patch for CGI::Pretty. > > Cheers, > Renee > --- > > renee.baecker@smart-websolutions.de > > Smart-Websolutions Andr? Windolph und Ren?e B?cker GbR > Maria-Montessori-Str. 13 > 64584 Biebesheim > > USt.-ID: DE 228 935 695 > > Telefon: 01803 - 278 25 51 98 (9 cent/Minute) > E-Mail: info@smart-websolutions.de > > Perl-Magazin: http://foo-magazin.de > Perl-Nachrichten: http://perl-nachrichten.de > > --- Pretty.pm.orig 2005-04-07 23:40:12.000000000 +0200 > +++ Pretty.pm 2008-08-27 13:14:00.000000000 +0200 > @@ -176,6 +176,13 @@ > } > sub _reset_globals { initialize_globals(); } > > +sub import { > + my ($package) = @_; > + > + no strict 'refs'; > + ${ "$package\::AutoloadClass" } = 'CGI'; > +} > + > 1; > > =head1 NAME > > > ----- End forwarded message ----- > -- Lincoln D. Stein Ontario Institute for Cancer Research 101 College St., Suite 800 Toronto, ON, Canada M5G0A3 416 673-8514 Assistant: Stacey Quinn <Stacey.Quinn@oicr.on.ca> Cold Spring Harbor Laboratory 1 Bungtown Road Cold Spring Harbor, NY 11724 USA (516) 367-8380 Assistant: Sandra Michelsen <michelse@cshl.edu>Thread Previous | Thread Next