2008/8/7 Ken Williams <kenahoo@gmail.com>: > On Tue, Aug 5, 2008 at 1:10 PM, Robert May <robertmay@cpan.org> wrote: >> Here's what I meant to attach. Against Bleed@34170 this time. Minor >> changes to what you extracted from my earlier 'patch' to get the >> generated code to compile under 5.6.1 and to modify MANIFEST to add >> the new test files. > > Okay, I've applied this to the SVN repo, and things seem to check out > on my end. I'll put together a beta release for testing. I see that there are a couple of failures on 5.6.2 test boxes - I said this would happen: > There is a problem that I haven't yet got to the bottom of with > compiling the new tests (XSUsage.xs) against 5.6.1. It's something to > do with the INTERFACE keyword, but it's not a new problem: it exists > with the xsubpp distributed with 5.6.1, so the easiest thing to do is > probably to skip the new tests on perl 5.6.x and earlier. Here's a patch to usage.t to skip the new tests on perl's before 5.8.0, as I don't have the time (or will) to investigate the INTERFACE keyword failures on 5.6.x. I think I've got the incantation right, but this is untested, as I'm travelling and don't have access to my build environments right now. Perhaps it should be 'TODO' rather than 'SKIP' ? Regards, Rob. diff U3 usage.t.orig usage.t --- usage.t.orig Thu Aug 07 08:48:02 2008 +++ usage.t Tue Aug 26 20:02:46 2008 @@ -7,6 +7,12 @@ or die "Can't chdir to lib/ExtUtils/ParseXS: $!"; @INC = qw(../.. ../../.. .); } + # TODO? Support for the INTERFACE keyword appears to be broken under perl 5.6.x + # (and elsewhere?). As a result the C code generated from XSUsage.xs won't compile. + if ($] < 5.008) { + print "1..0 # Skip -- INTERFACE keyword support broken before perl 5.8.x\n"; + exit 0; + } } use strict; use Test;Thread Previous | Thread Next