Re: [PATCH] Revert portion of Change 34200

Jerry D. Hedden schrieb:
> The attached patch reverts a portion of change 34200 that causes tests to fail.
> For example:
> 
>> PERL_CORE=1 ./perl.exe -Ilib lib/ExtUtils/ParseXS/t/basic.t
> 1..10
> # Running under perl version 5.011000 for cygwin
> # Current time local: Fri Aug 22 13:06:29 2008
> # Current time GMT:   Fri Aug 22 17:06:29 2008
> # Using Test.pm version 1.25
> ok 1
> ok 2
> ok 3
> ok 4
> ok 5
> XSTest.o:XSTest.c:(.text+0x15): undefined reference to `_Perl_Gthr_key_ptr'
> XSTest.o:XSTest.c:(.text+0x25): undefined reference to `_Perl_Istack_sp_ptr'
> XSTest.o:XSTest.c:(.text+0x2e): undefined reference to `_Perl_Gthr_key_ptr'
> XSTest.o:XSTest.c:(.text+0x3e): undefined reference to
> `_Perl_Imarkstack_ptr_ptr'
> XSTest.o:XSTest.c:(.text+0x4e): undefined reference to `_Perl_Gthr_key_ptr'
> ...

That's a symptom for having a wrong libperl.a

--- perl-current/lib/ExtUtils/CBuilder/Platform/cygwin.pm
+++ perl-current/lib/ExtUtils/CBuilder/Platform/cygwin.pm
@@ -17,9 +17,9 @@

  sub link {
    my ($self, %args) = @_;
-  # libperl.dll.a fails with -Uusedl. -L../CORE -lperl is better
+
    $args{extra_linker_flags} = [
-    '-L'.$self->perl_inc().' -lperl',
+    File::Spec->catdir($self->perl_inc(), 'libperl.dll.a'),
      $self->split_like_shell($args{extra_linker_flags})
    ];

Reverting this would break -Uusedl.
As my comment said:
libperl.dll.a fails with -Uusedl. -L../CORE -lperl is better


-- 
Reini Urban
http://phpwiki.org/  http://murbreak.at/

• [PATCH] Revert portion of change 34200 by Jerry D. Hedden
• [PATCH] Revert portion of Change 34200 by Jerry D. Hedden
• Re: [PATCH] Revert portion of Change 34200 by Reini Urban