[perl #57554] Problem globbing in a Safe Compartment

# New Ticket Created by  "Tom Goldrick" 
# Please include the string:  [perl #57554]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=57554 >


Message-Id: <5.8.8_1100_1217785564@DADDYSPC>

This is a bug report for perl from tggbiz@ntlworld.com,
generated with the help of perlbug 1.35 running under perl v5.8.8.


-----------------------------------------------------------------
[Please enter your report here]

Under normal circumstances globbing does not work in a Safe compartment,
despite an empty deny only list, though I have found a horrible workaround.

In order to reproduce the results just paste the code into 3 files
(SafeGlobDemo.pl, rdo.pl, glob.pl) as indicated.

I have included test results with Perl 5.10 as well as 5.8 - note that they
fail in different ways but the same workaround works for both. 

# Begin File: SafeGlobDemo.pl
#
use strict;
use warnings;

use Safe;

print "Running SafeGlobDemo\n";

do_list_files('*');


sub some_sub
{
}

sub do_list_files
{
    my $filespec = shift;
    print "do_list_files: Listing $filespec\n";
    my $cpt = load_compartment(__PACKAGE__, 'some_sub');

    if (defined($cpt) && exists &{$cpt->varglob('list_files')})
    {
        print "do_list_files: Calling rdo.pl list_files\n";
        &{$cpt->varglob('list_files')}($filespec);
    }
}

sub load_compartment
{
    my ($package, @subs) = @_;
    my $cpt;
    print "load_compartment\n";
    if (-f 'rdo.pl')
    {
        $cpt = new Safe;
        print "load_compartment: Doing rdo.pl\n";
        $cpt->share_from('main', [ '%ENV' ]);
        if (@ARGV > 0)
        {
            # Invoke horrible workaround!
            require 'glob.pl';
            $cpt->share_from('main', [ 'CORE::GLOBAL::glob' ]);
        }
        $cpt->share_from($package, [ @subs ]);
        $cpt->deny_only();
        $cpt->rdo('rdo.pl');
        if ($@)
        {
            die "Thrown exception from rdo.pl: $@\n";
        }
    }
    return $cpt;
}

# End File: SafeGlobDemo.pl

# Begin File: rdo.pl
#
use strict;
use warnings;

print "Loading rdo.pl\n";

sub list_files
{
    my $filespec = shift;

    for my $file (glob($filespec))
    {
        print "\tFound $file in rdo\n";
    }
}

# End File: rdo.pl

# Begin File: glob.pl
#
print "Loading glob.pl\n";

for (glob('*'))
{
   print ("\tFound $_\n");
}

1;

# End File: glob.pl

# End Code







# Test Results

# Begin Tests on Perl 5.10

# Test failure

C:\GLB\test\SafeGlobDemo>perl SafeGlobDemo.pl
Running SafeGlobDemo
do_list_files: Listing *
load_compartment
load_compartment: Doing rdo.pl
Thrown exception from rdo.pl: Undefined subroutine &Internals::SvREADO
+NLY called at C:/Perl/lib/constant.pm line 111.
BEGIN failed--compilation aborted at C:/Perl/lib/ActiveState/Path.pm l
+ine 11.
Compilation failed in require at C:/Perl/lib/ActivePerl/Config.pm line
+ 46.
Compilation failed in require at C:/Perl/lib/XSLoader.pm line 104.
Compilation failed in require at rdo.pl line 10.
BEGIN failed--compilation aborted at rdo.pl line 10.

# Workaround

C:\GLB\test\SafeGlobDemo>perl SafeGlobDemo.pl xxx
Running SafeGlobDemo
do_list_files: Listing *
load_compartment
load_compartment: Doing rdo.pl
Loading glob.pl
        Found glob.pl
        Found rdo.pl
        Found SafeGlobDemo.pl
Loading rdo.pl
do_list_files: Calling rdo.pl list_files
        Found glob.pl in rdo
        Found rdo.pl in rdo
        Found SafeGlobDemo.pl in rdo

C:\GLB\test\SafeGlobDemo>perl -v

This is perl, v5.10.0 built for MSWin32-x86-multi-thread
(with 5 registered patches, see perl -V for more detail)

Copyright 1987-2007, Larry Wall

Binary build 1003 [285500] provided by ActiveState http://www.ActiveSt
+ate.com
Built May 13 2008 16:52:49

Perl may be copied only under the terms of either the Artistic License
+ or the
GNU General Public License, which may be found in the Perl 5 source ki
+t.

Complete documentation for Perl, including FAQ lists, should be found 
+on
this system using "man perl" or "perldoc perl".  If you have access to
+ the
Internet, point your browser at http://www.perl.org/, the Perl Home Pa
+ge.

# End Tests on Perl 5.10

# Begin Tests on Perl 5.8

# Test failure

D:\GLB\test\SafeGlobDemo>perl SafeGlobDemo.pl
Running SafeGlobDemo
do_list_files: Listing *
load_compartment
load_compartment: Doing rdo.pl
Thrown exception from rdo.pl: Can't locate object method "can" via pac
+kage "DynaLoader" at C:/Perl/lib/XSLoader.pm line 90.
Compilation failed in require at rdo.pl line 10.
BEGIN failed--compilation aborted at rdo.pl line 10.


# Workaround

D:\GLB\test\SafeGlobDemo>perl SafeGlobDemo.pl xxx
Running SafeGlobDemo
do_list_files: Listing *
load_compartment
load_compartment: Doing rdo.pl
Loading glob.pl
        Found glob.pl
        Found rdo.pl
        Found SafeGlobDemo.pl
Loading rdo.pl
do_list_files: Calling rdo.pl list_files
        Found glob.pl in rdo
        Found rdo.pl in rdo
        Found SafeGlobDemo.pl in rdo

D:\GLB\test\SafeGlobDemo>perl -v

This is perl, v5.8.8 built for MSWin32-x86-multi-thread
(with 18 registered patches, see perl -V for more detail)

Copyright 1987-2007, Larry Wall

Binary build 822 [280952] provided by ActiveState http://www.ActiveSta
+te.com
Built Jul 31 2007 19:34:48

Perl may be copied only under the terms of either the Artistic License
+ or the
GNU General Public License, which may be found in the Perl 5 source ki
+t.

Complete documentation for Perl, including FAQ lists, should be found 
+on
this system using "man perl" or "perldoc perl".  If you have access to
+ the
Internet, point your browser at http://www.perl.org/, the Perl Home Pa
+ge.

# End Tests on Perl 5.8



[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags:
    category=core
    severity=high
---
Site configuration information for perl v5.8.8:

Configured by SYSTEM at Tue Jul 31 19:34:29 2007.

Summary of my perl5 (revision 5 version 8 subversion 8) configuration:
  Platform:
    osname=MSWin32, osvers=5.00, archname=MSWin32-x86-multi-thread
    uname=''
    config_args='undef'
    hint=recommended, useposix=true, d_sigaction=undef
    usethreads=define use5005threads=undef useithreads=define usemultiplicity=define
    useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
    use64bitint=undef use64bitall=undef uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cl', ccflags ='-nologo -GF -W3 -MD -Zi -DNDEBUG -O1 -DWIN32 -D_CONSOLE -DNO_STRICT -DHAVE_DES_FCRYPT -DNO_HASH_SEED -DUSE_SITECUSTOMIZE -DPRIVLIB_LAST_IN_INC -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -DPERL_MSVCRT_READFIX',
    optimize='-MD -Zi -DNDEBUG -O1',
    cppflags='-DWIN32'
    ccversion='12.00.8804', gccversion='', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=8
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='__int64', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='link', ldflags ='-nologo -nodefaultlib -debug -opt:ref,icf  -libpath:"C:\Perl\lib\CORE"  -machine:x86'
    libpth=\lib
    libs=  oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib  netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib  version.lib odbc32.lib odbccp32.lib msvcrt.lib
    perllibs=  oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib  netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib  version.lib odbc32.lib odbccp32.lib msvcrt.lib
    libc=msvcrt.lib, so=dll, useshrplib=true, libperl=perl58.lib
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -debug -opt:ref,icf  -libpath:"C:\Perl\lib\CORE"  -machine:x86'

Locally applied patches:
    ACTIVEPERL_LOCAL_PATCHES_ENTRY
    Iin_load_module moved for compatibility with build 806
    Avoid signal flag SA_RESTART for older versions of HP-UX
    PerlEx support in CGI::Carp
    Less verbose ExtUtils::Install and Pod::Find
    Patch for CAN-2005-0448 from Debian with modifications
    Rearrange @INC so that 'site' is searched before 'perl'
    Partly reverted 24733 to preserve binary compatibility
    MAINT31223 plus additional changes
    31490 Problem bootstraping Win32CORE
    31324 Fix DynaLoader::dl_findfile() to locate .so files again
    31214 Win32::GetLastError fails when first called
    31211 Restore Windows NT support
    31188 Problem killing a pseudo-forked child on Win32
    29732 ANSIfy the PATH environment variable on Windows
    27527,29868 win32_async_check() can loop indefinitely
    26970 Make Passive mode the default for Net::FTP
    26379 Fix alarm() for Windows 2003
    24699 ICMP_UNREACHABLE handling in Net::Ping

---
@INC for perl v5.8.8:
    C:/Perl/site/lib
    C:/Perl/lib
    .

---
Environment for perl v5.8.8:
    HOME (unset)
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=C:\Program Files\Microsoft.NET\SDK\v1.1\bin;C:\Program Files\Microsoft Visual Studio .NET 2003\Common7\IDE;C:\Program Files\Microsoft Visual Studio .NET 2003\VC7\BIN;C:\Program Files\Microsoft Visual Studio .NET 2003\Common7\Tools;C:\Program Files\Microsoft Visual Studio .NET 2003\Common7\Tools\bin\prerelease;C:\Program Files\Microsoft Visual Studio .NET 2003\Common7\Tools\bin;C:\Program Files\Microsoft Visual Studio .NET 2003\SDK\v1.1\bin;C:\WINDOWS\Microsoft.NET\Framework\v1.1.4322;C:\WINDOWS\system32;;C:\Program Files\Java\jdk1.5.0_04\bin;C:\Program Files\Java\apache-ant-1.6.5\bin;C:\Program Files\Java\Apache Software Foundation\ActiveMQ\apache-activemq-4.1.1\bin;C:\Program Files\Java\java_ee_sdk-5_03\bin;C:\Perl\bin;C:\Documents and Settings\Daddy\My Documents\Work\auto\glb\tool\Windows\bin
    PERLPATH=C:\Perl
    PERL_BADLANG (unset)
    SHELL (unset)

• [perl #57554] Problem globbing in a Safe Compartment by Tom Goldrick