develooper Front page | perl.perl5.porters | Postings from July 2008

Re: [PATCH] ExtUtils::ParseXS - Error reporting problem with INTERFACE and ALIAS keywords

Thread Previous | Thread Next
From:
Robert May
Date:
July 31, 2008 01:02
Subject:
Re: [PATCH] ExtUtils::ParseXS - Error reporting problem with INTERFACE and ALIAS keywords
Message ID:
54bdc7510807310102h6b16cd3ch5cbe68f6caf6664e@mail.gmail.com
2008/7/31 Ken Williams <kenahoo@gmail.com>:
> Thanks, I've applied your patch to the SVN copy of EU::PXS.  There
> were a couple of tweaks necessary because:
>
> 1) there was some extra blib/ stuff in your patch

Oops. Sorry. It appears I attached a completely wrong patch file -
against my working copy, not against blead at all.  Fortunately it
seems you have been clever enough to extract most of what I intended -
but there are some further tweaks I made (mostly to get it to work on
perl 5.6.1).

> 2) blead@34160 is relatively old.

OK. I though I did a successful rsync before I started, but I will check.

> A revised patch for blead is attached.  All tests (including your new
> ones) pass for me against 5.8.8 and 5.10.0 on OS X 10.5.

The MANIFEST needs patching to add the new test files too.

I'll generate a new patch against blead next time I'm in front of a
suitable machine (may not be until the weekend).


> On perl 5.8.8 I still get a bunch of unsightly warnings about "passing
> argument 4 of 'Perl_newXS' discards qualifiers from pointer target
> type", probably relating to the "const char* file = __FILE__;" changes
> from a while back.

Definitely due to the "const char* file = __FILE__;" - I rolled that
change back to check.

> The only remaining thing I'd love it if you could provide is a nice
> terse summary for the 'Changes' file.  If you have such a thing, let
> me know.

I'll work on something and provide it along with an updated patch file.

Thanks,
Rob.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About