develooper Front page | perl.perl5.porters | Postings from June 2008

[perl #56340] encode() with FB_CROAK may destroy its argument

From:
Alex Kapranoff
Date:
June 25, 2008 10:03
Subject:
[perl #56340] encode() with FB_CROAK may destroy its argument
Message ID:
rt-3.6.HEAD-6656-1214399234-128.56340-75-0@perl.org
# New Ticket Created by  Alex Kapranoff 
# Please include the string:  [perl #56340]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=56340 >



This is a bug report for perl from alex@kapranoff.ru,
generated with the help of perlbug 1.36 running under perl 5.10.0.


-----------------------------------------------------------------
[Please enter your report here]

Standard Encode::encode() function with non-FB_DEFAULT argument
and 'utf-7' encoding always kills its data argument.

use Encode;

my $s = 'test';
my $s2 = $s;

my $enc = find_encoding('utf-7');

$enc->encode($s);
warn "encode '$s' ne '$s2'\n" if $s ne $s2;

$enc->encode($s, Encode::FB_CROAK | Encode::LEAVE_SRC);
warn "encode w. FB_CROAK '$s' ne '$s2'\n" if $s ne $s2;

Encode POD suggests using LEAVE_SRC bit, but it's not used inside
utf-7 codec so it has no effect.

Here's a patch against bleadperl as of today:

--- UTF7.pm.orig	2008-06-25 16:25:57.000000000 +0400
+++ UTF7.pm	2008-06-25 17:01:58.000000000 +0400
@@ -52,7 +52,7 @@
              die "This should not happen! (pos=" . pos($str) . ")";
          }
      }
-    $_[1] = '' if $chk;
+    $_[1] = '' if $chk && ($chk & Encode::LEAVE_SRC) == 0;
      return $bytes;
  }


[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags:
     category=core
     severity=critical
---
Site configuration information for perl 5.10.0:

Configured by kappa at Tue Dec 18 22:42:37 MSK 2007.

Summary of my perl5 (revision 5 version 10 subversion 0) configuration:
   Platform:
     osname=linux, osvers=2.6.22-14-generic, 
archname=i686-linux-thread-multi-64int-ld
     uname='linux aukland 2.6.22-14-generic #1 smp sun oct 14 23:05:12 
gmt 2007 i686 gnulinux '
     config_args=''
     hint=recommended, useposix=true, d_sigaction=define
     useithreads=define, usemultiplicity=define
     useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
     use64bitint=define, use64bitall=undef, uselongdouble=define
     usemymalloc=n, bincompat5005=undef
   Compiler:
     cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing 
-pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
     optimize='-O2',
     cppflags='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe 
-I/usr/local/include'
     ccversion='', gccversion='4.1.3 20070929 (prerelease) (Ubuntu 
4.1.2-16ubuntu2)', gccosandvers=''
     intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=12345678
     d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
     ivtype='long long', ivsize=8, nvtype='long double', nvsize=12, 
Off_t='off_t', lseeksize=8
     alignbytes=4, prototype=define
   Linker and Libraries:
     ld='cc', ldflags =' -L/usr/local/lib'
     libpth=/usr/local/lib /lib /usr/lib /usr/lib64
     libs=-lnsl -lgdbm -ldl -lm -lcrypt -lutil -lpthread -lc
     perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
     libc=/lib/libc-2.6.1.so, so=so, useshrplib=false, libperl=libperl.a
     gnulibc_version='2.6.1'
   Dynamic Linking:
     dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
     cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib'

Locally applied patches:


---
@INC for perl 5.10.0:
     /site/lib
     /usr/local/lib/perl5/5.10.0/i686-linux-thread-multi-64int-ld
     /usr/local/lib/perl5/5.10.0
     /usr/local/lib/perl5/site_perl/5.10.0/i686-linux-thread-multi-64int-ld
     /usr/local/lib/perl5/site_perl/5.10.0
     .

---
Environment for perl 5.10.0:
     HOME=/home/kappa
     LANG=ru_RU.UTF-8
     LANGUAGE (unset)
     LD_LIBRARY_PATH (unset)
     LOGDIR (unset)
 
PATH=/home/kappa/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
     PERLLIB=/site/lib
     PERL_BADLANG (unset)
     SHELL=/usr/bin/zsh




nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About