develooper Front page | perl.perl5.porters | Postings from June 2008

[perl #55844] [PATCH] perlbug refactoring and prose cleanup

Thread Next
From:
Jesse
Date:
June 15, 2008 15:48
Subject:
[perl #55844] [PATCH] perlbug refactoring and prose cleanup
Message ID:
rt-3.6.HEAD-18229-1213543909-1580.55844-75-0@perl.org
# New Ticket Created by  Jesse 
# Please include the string:  [perl #55844]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=55844 >


The attached patch includes all n patches to perlbug.PL I submitted  
last week.

It includes all the following changes and has been recast to apply to  
perlbug.PL rather than perlbug itself.


> This morning, clkao pinged me and mentioned that he couldn't get  
> perlbug to set the From: header when sending a bug report.  I  
> promised him I'd take a look.
>
> I opened up perlbug determined to add one line and send a patch.  
> Somehow, I never got around to adding the line CL asked for as I got  
> distracted by the prose of the tool.
>
> Attached is a patch which rewrites most of the text (both within the  
> tool and in the POD). It also replaced a couple of string evals with  
> block evals, though that could be extracted to a separate patch if  
> needed.
>
> The attached patch unifies perlbug's prompting into a single sub,  
> replacing 15 different similar but not quite identical handcoded  
> prompts.
>
> It also cleans up Alexandr Ciornii's Module::CoreList support to  
> actually enforce the restriction stopping users from using perlbug  
> to report bugs in non-core CPAN modules and actually records the  
> module name the user enters in the 'flags' section of the bug report.
>
> # Changed in 1.39 Trap mail sending failures (simple ones) so    
> JESSE 2008-06-08
> #                 users might be able to recover their bug reports
> #                 Refactor mail sending routines
> #                 Unify message building code
> #                 Unify message header building
> #                 Fix "module" prompting to not squish "category"  
> prompting
> #                 use warnings; (except 'once' warnings)
> #                 Unified report fingerprint/change detection code
> #                 Removed some labeled 'gotos'



Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About