Front page | perl.perl5.porters |
Postings from June 2008
Craig A. Berry wrote: > On Thu, Jun 12, 2008 at 7:50 PM, John E. Malmberg <wb8tyw@qsl.net> wrote: >> Even though configure.com was detecting the getgrgid and friends, they were >> not being configured because HAS_GROUPS was not defined in vmsish.h. > > Good catch. Obviously it's HAS_GROUP, not HAS_GROUPS, but that's > correct in the patch itself. I am evaluating what is left to be done for supporting ODS-5 pathnames by looking to see what is currently being skipped or failing when I turn on the DECC features. >> --- /rsync_root/perl/vms/vmsish.h Thu Feb 21 18:20:57 2008 >> +++ vms/vmsish.h Thu Jun 12 08:34:47 2008 >> @@ -448,8 +448,15 @@ >> * This symbol, if defined, indicates that the getgrnam() and >> * getgrgid() routines are available to get group entries. >> * The getgrent() has a separate definition, HAS_GETGRENT. >> + * >> + * These have been available in VMS for a while, but configure.com >> + * only checks for the recursive versions. > > The _r is for reentrant, not recursive. Opps, I do not know why I wrote that. >> */ >> +#if defined HAS_GETGRNAM_R || defined HAS_GETGRGID_R > > Wouldn't it be simpler to just do: > > #if __CRTL_VER >= 70302000 > > plus that self-documents when they became available. The reason I used the symbols is that I was not sure if Configure exposed them at the same as they showed up in VMS. -John wb8tyw@qsl.net Personal Opinion OnlyThread Previous | Thread Next