develooper Front page | perl.perl5.porters | Postings from June 2008

Re: Change 34005: Re: CPAN Upload: S/SA/SAPER/Sys-Syslog-0.25.tar.gz

Thread Previous | Thread Next
From:
=?iso-8859-1?b?U+liYXN0aWVu?= Aperghis-Tramoni
Date:
June 12, 2008 02:29
Subject:
Re: Change 34005: Re: CPAN Upload: S/SA/SAPER/Sys-Syslog-0.25.tar.gz
Message ID:
1213262896.4850ec301512e@imp.free.fr
Nicholas Clark wrote:

> On Thu, Jun 12, 2008 at 03:13:51AM +0200, Sbastien Aperghis-Tramoni wrote:
>
> > "All tests successful" on 5.6.2, 5.8.3, 5.8.4, 5.8.6, 5.10.0. Also
> > pass on 5.5.3 event though there's this warning:
> > Character class syntax [: :] is reserved for future extensions at
> > blib/lib/ExtUtils/Constant/Utils.pm line 58
>
> Thanks.
>
> > All on OSX.4.11 PowerPC, GCC 4.0.1. I'll check tomorrow at $work on
> > Linux x86-64.

Confirmed to pass tests on Linux x86-64, GCC 4.0.1, wit Perl 5.6.2,
5.8.7, 5.8.8, 5.10.0


Fails on 5.6.0 with thi serror:
t/Constant....Can't locate ExtUtils/Constant/Aaargh56Hash.pm in @INC


Fails on 5.5.3 and 5.5.4 with this error:
t/Constant....Character class syntax [: :] is reserved for future extensions at
blib/lib/ExtUtils/Constant/Utils.pm line 58.
Character class syntax [: :] is reserved for future extensions at
blib/lib/ExtUtils/Constant/Utils.pm line 95.
t/Constant....FAILED test 9
        Failed 1/239 tests, 99.58% okay (less 10 skipped tests: 228 okay,
95.40%)

Test 9 being:
not ok 9 # $not_zero=1.84467440737096e+19 ~0=4294967295


Same thing on 5.4.5 but with different warnings:

$ /usr/local/bin/perl5.4.5 -wIlib t/Constant.t
# perl=/usr/local/bin/perl5.4.5
# ext-25514 being created...
1..239
# Simple tests
# ext-25514/0 being created...
ok 1
ok 2
# Makefile.PL is 0 second(s) older than Makefile
# make = '/usr/bin/make'
In file included from ExtTest.xs:4:
test.h:6:1: warning: "Yes" redefined
In file included from
/usr/local/perl/5.4.5/lib/x86_64-linux/5.00405/CORE/perl.h:30,
                 from ExtTest.xs:2:
/usr/local/perl/5.4.5/lib/x86_64-linux/5.00405/CORE/embed.h:27:1: warning: this
is the location of the previous definition
In file included from ExtTest.xs:4:
test.h:7:1: warning: "No" redefined
In file included from
/usr/local/perl/5.4.5/lib/x86_64-linux/5.00405/CORE/perl.h:30,
                 from ExtTest.xs:2:
/usr/local/perl/5.4.5/lib/x86_64-linux/5.00405/CORE/embed.h:24:1: warning: this
is the location of the previous definition
ok 3
ok 4 # This is dynamic linking, so no need to make perl
# make = '/usr/bin/make test'
ok 5
ok 6
ok 7
ok 8
not ok 9 # $not_zero=1.84467440737096e+19 ~0=4294967295
...


> > I see that its kwalitee can be improved. I'll send you a patch tomorrow.
>
> I had a suspicion that this would be the case. However the CPANTS server had
> lost its mind last night (404 on /) so I couldn't see what I was failing on
> that I cared about.

It's easy to cheat: just install Module::CPANTS::Analyse and the cpants_lint
command to locally check the distribution.
  ┬╗ http://search.cpan.org/dist/Module-CPANTS-Analyse/


-- 
S├ębastien Aperghis-Tramoni

Close the world, txEn eht nepO.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About