develooper Front page | perl.perl5.porters | Postings from June 2008

RE: [perl #55162] Re: File::Spec Cygwin/Win32 case_tolerant improvement

Thread Previous | Thread Next
Jan Dubois
June 2, 2008 13:15
RE: [perl #55162] Re: File::Spec Cygwin/Win32 case_tolerant improvement
Message ID:
On Mon, 02 Jun 2008, Reini Urban via RT wrote:
> Oops, I did it again.

My eyes! The goggles do nothing!

> Attached is the fixed 511 - blead patch without
> syntax error.

I don't like the hard-coded "C:" in your patch.  Assuming you want to
specify the drive where Windows itself was installed, you should
write something like this:

  drive ||= $ENV{SYSTEMDRIVE} || substr($ENV{WINDIR}, 0, 2);

The reference to WINDIR is only for Win9X, which doesn't have
SYSTEMDRIVE. You could also probably just use WINDIR everywhere.


PS: If you do another patch to the file, could you also do
    s/MsWin32/MSWin32/g as well?  Thanks!

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About