Front page | perl.perl5.porters |
Postings from June 2008
On Mon, 02 Jun 2008, Reini Urban via RT wrote:
> Oops, I did it again.
My eyes! The goggles do nothing!
> Attached is the fixed 511 - blead patch without
> syntax error.
I don't like the hard-coded "C:" in your patch. Assuming you want to
specify the drive where Windows itself was installed, you should
write something like this:
drive ||= $ENV{SYSTEMDRIVE} || substr($ENV{WINDIR}, 0, 2);
The reference to WINDIR is only for Win9X, which doesn't have
SYSTEMDRIVE. You could also probably just use WINDIR everywhere.
Cheers,
-Jan
PS: If you do another patch to the file, could you also do
s/MsWin32/MSWin32/g as well? Thanks!
Thread Previous
|
Thread Next