[perl #54828] perlio.c has a problem (both 5.8 and 5.10)

# New Ticket Created by  "Goro Fuji" 
# Please include the string:  [perl #54828]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=54828 >


Hi.

I think perlio.c has an issue in PerlIORaw_pushed().
It may cause segmentation fault or invalid abortion in (at least)
MSWin32 ActivePerl 5.10.0 and Cygwin Perl 5.8.8 and 5.10.0.

The problem is that PerlIORaw_pushed() may supply a layer's Binmode()
with an invalid function table. See the line 1293 at perlio.c of
5.10.0. At the line, Binmode() is called with "f", not "t". It seems a
mistake, because the argument is the method recerver, namely "self",
which has to match with the function. This is "t"'s Binmode() (==
"&l"'s) function, so the argument should be "t".

I have written a patch and test. Please see the attached.

Thanks.
---
Goro Fuji gfuji@cpan.org




-----------------------------------------------------------------
---
Flags:
    category=core
    severity=low
---
This perlbug was built using Perl v5.8.5 in the Red Hat build system.
It is being executed now by Perl v5.8.5 - Fri Dec 16 14:05:59 EST 2005.

Site configuration information for perl v5.8.5:

Configured by Red Hat, Inc. at Fri Dec 16 14:05:59 EST 2005.

Summary of my perl5 (revision 5 version 8 subversion 5) configuration:
  Platform:
    osname=linux, osvers=2.6.9-22.18.bz155725.elsmp,
archname=i386-linux-thread-multi
    uname='linux hs20-bc1-4.build.redhat.com
2.6.9-22.18.bz155725.elsmp #1 smp thu nov 17 15:34:08 est 2005 i686
i686 i386 gnulinux '
    config_args='-des -Doptimize=-O2 -g -pipe -m32 -march=i386
-mtune=pentium4 -Dversion=5.8.5 -Dmyhostname=localhost
-Dperladmin=root@localhost -Dcc=gcc -Dcf_by=Red Hat, Inc.
-Dinstallprefix=/usr -Dprefix=/usr -Darchname=i386-linux
-Dvendorprefix=/usr -Dsiteprefix=/usr -Duseshrplib -Dusethreads
-Duseithreads -Duselargefiles -Dd_dosuid -Dd_semctl_semun -Di_db
-Ui_ndbm -Di_gdbm -Di_shadow -Di_syslog -Dman3ext=3pm -Duseperlio
-Dinstallusrbinperl -Ubincompat5005 -Uversiononly
-Dpager=/usr/bin/less -isr -Dinc_version_list=5.8.4 5.8.3 5.8.2 5.8.1
5.8.0'
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=define use5005threads=undef useithreads=define
usemultiplicity=define
    useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
    use64bitint=undef use64bitall=undef uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='gcc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING
-fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -I/usr/include/gdbm',
    optimize='-O2 -g -pipe -m32 -march=i386 -mtune=pentium4',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING
-fno-strict-aliasing -pipe -I/usr/local/include -I/usr/include/gdbm'
    ccversion='', gccversion='3.4.5 20051201 (Red Hat 3.4.5-1)', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t',
lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='gcc', ldflags =' -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib
    libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc
    perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
    libc=/lib/libc-2.3.4.so, so=so, useshrplib=true, libperl=libperl.so
    gnulibc_version='2.3.4'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E
-Wl,-rpath,/usr/lib/perl5/5.8.5/i386-linux-thread-multi/CORE'
    cccdlflags='-fPIC', lddlflags='-shared -L/usr/local/lib'

Locally applied patches:


---
@INC for perl v5.8.5:
    /home1/s0710509/perl5/lib/perl5/5.8.5/5.8.5/i386-linux-thread-multi
    /home1/s0710509/perl5/lib/perl5/5.8.5/5.8.5
    /home1/s0710509/perl5/lib/perl5/5.8.5/i386-linux-thread-multi
    /home1/s0710509/perl5/lib/perl5/5.8.5/5.8.4
    /home1/s0710509/perl5/lib/perl5/5.8.5/5.8.3
    /home1/s0710509/perl5/lib/perl5/5.8.5/5.8.2
    /home1/s0710509/perl5/lib/perl5/5.8.5/5.8.1
    /home1/s0710509/perl5/lib/perl5/5.8.5/5.8.0
    /home1/s0710509/perl5/lib/perl5/5.8.5
    /home1/s0710509/perl5/lib/perl5/site_perl/5.8.5/5.8.5/i386-linux-thread-multi
    /home1/s0710509/perl5/lib/perl5/site_perl/5.8.5/5.8.5
    /home1/s0710509/perl5/lib/perl5/site_perl/5.8.5/i386-linux-thread-multi
    /home1/s0710509/perl5/lib/perl5/site_perl/5.8.5/5.8.4
    /home1/s0710509/perl5/lib/perl5/site_perl/5.8.5/5.8.3
    /home1/s0710509/perl5/lib/perl5/site_perl/5.8.5/5.8.2
    /home1/s0710509/perl5/lib/perl5/site_perl/5.8.5/5.8.1
    /home1/s0710509/perl5/lib/perl5/site_perl/5.8.5/5.8.0
    /home1/s0710509/perl5/lib/perl5/site_perl/5.8.5
    /usr/lib/perl5/5.8.5/i386-linux-thread-multi
    /usr/lib/perl5/5.8.5
    /usr/lib/perl5/site_perl/5.8.5/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.4/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.2/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.1/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.0/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.5
    /usr/lib/perl5/site_perl/5.8.4
    /usr/lib/perl5/site_perl/5.8.3
    /usr/lib/perl5/site_perl/5.8.2
    /usr/lib/perl5/site_perl/5.8.1
    /usr/lib/perl5/site_perl/5.8.0
    /usr/lib/perl5/site_perl
    /usr/lib/perl5/vendor_perl/5.8.5/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.4/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.3/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.2/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.1/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.0/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.5
    /usr/lib/perl5/vendor_perl/5.8.4
    /usr/lib/perl5/vendor_perl/5.8.3
    /usr/lib/perl5/vendor_perl/5.8.2
    /usr/lib/perl5/vendor_perl/5.8.1
    /usr/lib/perl5/vendor_perl/5.8.0
    /usr/lib/perl5/vendor_perl
    .

---
Environment for perl v5.8.5:
    HOME=/home1/s0710509
    LANG=ja_JP.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home1/s0710509/bin:/usr/kerberos/bin:/usr/java/jdk1.5.0_11/bin:/usr/java/jre1.5.0_11/bin:/usr/local/eclipse:/usr/local/netbeans-5.0/bin:/usr/local/Adobe/Acrobat7.0/bin:/usr/local/thunderbird:/usr/local/firefox:/usr/local/bin:/bin:/usr/bin:/usr/X11R6/bin
    PERL5LIB=/home1/s0710509/perl5/lib/perl5/5.8.5:/home1/s0710509/perl5/lib/perl5/site_perl/5.8.5
    PERL_BADLANG (unset)
    SHELL=/bin/bash

• [perl #54828] perlio.c has a problem (both 5.8 and 5.10) by Goro Fuji
• Re: [perl #54828] perlio.c has a problem (both 5.8 and 5.10) by Rafael Garcia-Suarez
• Re: [perl #54828] perlio.c has a problem (both 5.8 and 5.10) by Goro Fuji