Front page | perl.perl5.porters |
Postings from May 2008
Re: Some smoke digging
Thread Previous
|
Thread Next
From:
Craig A. Berry
Date:
May 23, 2008 14:28
Subject:
Re: Some smoke digging
Message ID:
c9ab31fc0805231428p5284e872kbd1d2a1b44668ac2@mail.gmail.com
On Fri, May 23, 2008 at 1:26 PM, Steve Peters <steve@fisharerojo.org> wrote:
> On Fri, May 23, 2008 at 4:21 AM, H.Merijn Brand <h.m.brand@xs4all.nl> wrote:
>> On Fri, 23 May 2008 09:05:57 +0200, "Rafael Garcia-Suarez"
>> <rgarciasuarez@gmail.com> wrote:
>>
>>> 2008/5/23 H.Merijn Brand <h.m.brand@xs4all.nl>:
>>> > The Time::Piece is currently being worked on. Gisle provided a patch to
>>> > Matt, as did Steve P, but using a quite different approach. I'm not the
>>> > one to decide which of the two is the best to use, but I'm confident
>>> > that that fail will be gone soon.
>>>
>>> I think Matt applied Gisle's patch. We can just wait until Matt
>>> releases a new version maybe ?
>>
>> Yes we could, but I sure like Matt's feedback here.
>>
>> I've seen Gisle's patch, and it is straightforward.
>> Don't know what Steve's patch would look like, but
>> if I go by the discussions so far it would be more
>> basic.
>>
>> --
>> H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
>> using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11,
>> & 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org
>> http://mirrors.develooper.com/hpux/ http://www.test-smoke.org
>> http://www.goldmark.org/jeff/stupid-disclaimers/
>>
>
> My was similar to Gisle's except that it was adding VMS and Tru64 to
> the list using Time::Piece's supplied strptime(). I'll add a comment
> to the RT ticket adding those two operating systems to the patch.
Actually Gisle's *second* patch, which is the one Matt applied, was
not really like yours; he followed his own suggestion to, "rework
add_months() to not rely on strptime being able to parse illegal
dates." See:
http://rt.cpan.org/Public/Bug/Display.html?id=36106
or the very end of:
http://www.nntp.perl.org/group/perl.perl5.porters/2008/05/msg137156.html
I have not tested it yet but this sounds to me like the better way to
go. For one thing it doesn't require maintaining a platform matrix in
the ifdefs. Your approach made sense as a safe fix that avoided
having to rethink Time::PIece internals (which I know I didn't have
time to do), but Gisle took care of that for us.
Thread Previous
|
Thread Next