develooper Front page | perl.perl5.porters | Postings from May 2008

Re: Should potentially confusing labels emit a warning?

Thread Previous | Thread Next
Nicholas Clark
May 15, 2008 02:06
Re: Should potentially confusing labels emit a warning?
Message ID:
On Thu, May 15, 2008 at 10:59:03AM +0200, Dominic Dunlop wrote:
> On 2008?05?15, at 10:27, Ed Avis wrote:
> >I think that a warning is a good idea - I can't imagine any false  
> >positives, and
> >you already have evidence that people tend to make this mistake.
> Trouble is, some of it's CGI, and people whinge loudly when previously- 
> clean CGI starts warning:
> < 
> >
> (Webloc attached, as the above is bound to be mangled, especially by  
> Mac OS X Mail.)

Well, something ate the attachment in transit, but from the 5 results I see
there, two are comments. One is

# remove all clients from "Add clients" list that already belong to search tag
BEGIN: foreach $line(@AllClients) {
chomp $line;

        foreach $match(@RemoveClients) {
        if ($line eq $match) {

        next BEGIN;

push @newAllClients,$line;

and the other two are (near) duplicates:

use vars qw( $JSMenuBar $JSIndexPage $JSMesgPage );

The former wouldn't warn if we could arrange that only /BEGIN:\s*{/ warned.
The latter looks like a bug. (But I suspect that it's actually not, just a
code style I've not met, as there's a MAIN: { ... } later on.

Nicholas Clark

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About