develooper Front page | perl.perl5.porters | Postings from April 2008

Re: [PATCH] Double magic/warnings with binmode $fh, undef

Thread Previous
From:
Rafael Garcia-Suarez
Date:
April 30, 2008 01:18
Subject:
Re: [PATCH] Double magic/warnings with binmode $fh, undef
Message ID:
b77c1dce0804300118t500680d2r85aabb4270298e9e@mail.gmail.com
2008/4/29 Vincent Pit <perl@profvince.com>:
> Hi.
>  binmode $fh, $x calls get magic twice on $x and triggers "undefined"
>  warnings twice too when $x isn't defined. The attached patch fixes this by
>  making doio.c:Perl_mode_from_discipline() take a const char * and the
>  according STRLEN as arguments instead of a SV, so that we can remove the
>  SvPV_const() inside. This changes the interface but since it's not part of
>  the public API it should be OK. Regen and tested against 33763.

Thanks, applied as #33766.

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About