On Mon, Mar 10, 2008 at 11:03:26AM -0700, Jan Dubois wrote: > Yes, the PERL_BITFIELDS stuff breaks binary compatibility for VC, so it > cannot go into 5.10. We'll just have to live with the bloated OP > structures; it doesn't really matter that much. > > Note that Cygwin doesn't use the win32/* files at all, so it won't use > -mms-bitfields even in blead. > > I can see an argument for using it though: Unix originated sources > will only used 'int' or 'unsigned int' as the base type for bit- > fields, so nothing will change for them. But all files using Windows > specific headers > (e.g. Platform SDK) will only be compiled correctly when you use -mms- > bitfields. > > When I was looking into some documentation on -mms-bitfields I noticed > that virtually al Gtk based software recommends that you compile it with > -mms-bitfields on Windows, even under Cygwin. So I think adding -mms- > bitfields to Cygwin may help building XS code using such libraries. > > Note that you can't add it to Cygwin for 5.10 anymore for the same > reason we can't apply the PERL_BITFIELDS stuff to 5.10.1: it will break > compatibility with Perl 5.10.0. > > Cheers, > -Jan On Tue, Mar 11, 2008 at 07:25:27PM +0100, Reini Urban wrote: > 2008/3/10, Nicholas Clark <nick@ccl4.org>: > > On Sat, Mar 08, 2008 at 08:55:36PM +0100, Reini Urban wrote: > > > * Update README for the ld2 axe, and a bit more. Applied to maint-5.8 as change 33484 > > > * CYG04 At least on cygwin strip the last number > > > from the dll. This is in the cygwin.com build since years. > > > > > > None of these changes are in blead. Assuming that they are relevant to 5.11, > > 5.10.1-tobe and 5.8.9-tobe, should I just apply them there and merge them > > across? > > please. > > The changes that prompted this (to structure members of op.h) didn't (can't) > > go back into 5.8.x, so is it needed? > > No, not needed. The bitfield changes and following MSVC quirks for Win32::GUI > just came with 5.10 and blead. Applied to blead as change 33481 Based on what Jan said about 5.10.x, (for now) I've integrated all bar the -mms-bitfields in CFLAGS part to maint-5.10 as change 33484. (Before I forget about the special case) > > > * CYG01 update hints from blead > > > > I'll just merge that from blead then. > > Thanks. > But take care, blead has wrong archname now. I did this by accident. > archname="cygwin" it should be. > blead patch pending. Aha. I wasn't aware of that, and hadn't waited for your reply before merging them. So that mistake is propagated everywhere. :-( > > > > * CYG09 enhance GetCurrentThreadId test > > > > This is appropriate for blead and 5.10.x too? > > yes, for all three. I posted them a long time ago. Applied to blead as change 33480 > > > * CYG10 improve Win32::GetLastError test > > > > And this? > > ditto. both tests are just minor nitpicks. Applied to blead as change 33482 I'll give it about 24 hours before merging the rest to maint-5.10 and then maint-5.8, to see what the smokes (automatic or manual) bring. Nicholas ClarkThread Previous | Thread Next