Front page | perl.perl5.porters |
Postings from March 2008
On Fri, Mar 07, 2008 at 07:49:28AM +0300, Alexey Tourbin wrote:
> This part of "Change 33421: Re-run regen.pl..." should be reverted:
>
> --- a/proto.h
> +++ b/proto.h
> @@ -1698,13 +1698,11 @@ STATIC void S_usage(pTHX_ const char *name);
> #ifdef DOSUID
> # ifdef IAMSUID
> STATIC void S_validate_suid(pTHX_ const char *validarg, int fdscript, bool suidscript, SV* linestr_sv);
> -# else
> STATIC void S_validate_suid(pTHX_ const char *validarg, const char *scriptname, int fdscript, SV* linestr_sv);
> # endif
> #else
> # ifndef SETUID_SCRIPTS_ARE_SECURE_NOW
> STATIC void S_validate_suid(pTHX);
> -
> # endif
> #endif
Well, it's somewhat hard to revert a generated file and have it stick.
It tends to come back like {insert cliché here}
The real fix is to put the #else back into embed.fnc.
Thanks for spotting this.
Nicholas Clark
Thread Previous
|
Thread Next