On 27/02/2008, Linda W <perl-diddler@tlinx.org> wrote: > Robin Barker wrote: > > > > From: Linda W [mailto:perl-diddler@tlinx.org] > > --- lib/ExtUtils/Install.pm 2007-09-09 16:17:23.000000000 -0700 > > +++ lib/ExtUtils/Install.pm 2008-02-27 03:39:18.110625000 -0800 > > @@ -436,7 +436,8 @@ > > my $path=''; > > my @make; > > while (@dirs) { > > - $dir = File::Spec->catdir($vol,@dirs); > > + $dir = File::Spec->catdir(@dirs); > > + $dir = File::Spec->catpath($vol,$dirs) if length $vol; > > next if ( $dir eq $path ); > > if ( ! -e $dir ) { > > unshift @make,$dir; > > End of patch > > > > The C<$dirs> in the second added line looks like a typo; > > I think it should be C<$dir> (or possibly C<@dirs>). > > > > ---- > Right. After I installed and checked it, when I went > back to look, it pulled out a fresh copy of the source, and I retyped > what I had entered...(and added an 's' after 2nd $dir in line)... > thanks for pointing that out. It was a bit of an odd hour for me to be > trying patches..:-) > Please could you download EU::I 1.45 from search.cpan.org and verify that it fixes this behaviour? Also be aware that File::Spec->catpath() the file argument is not optional. If you do not provide a value many versions of FS will throw ugly warnings. The workaround is to use an empty string. http://search.cpan.org/CPAN/authors/id/Y/YV/YVES/ExtUtils-Install-1.45.tar.gz Cheers, Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"Thread Previous | Thread Next